Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 598923002: Removed the ScriptedSpeech content side. (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed the ScriptedSpeech content side. Removal the corresponding changes in blink are applied in the following patch https://codereview.chromium.org/599863002/ BUG=402536 Committed: https://crrev.com/6b8dda12a7d842517c5c4ee155cf48951e908a7f Cr-Commit-Position: refs/heads/master@{#296655}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added changes for removal of kEnableSpeechRecognition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
MRV
PTAL
6 years, 3 months ago (2014-09-24 09:00:56 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/598923002/diff/1/content/child/runtime_features.cc File content/child/runtime_features.cc (left): https://codereview.chromium.org/598923002/diff/1/content/child/runtime_features.cc#oldcode119 content/child/runtime_features.cc:119: if (!command_line.HasSwitch(switches::kEnableSpeechRecognition)) Please also remove the definition of the ...
6 years, 3 months ago (2014-09-24 15:29:56 UTC) #3
MRV
On 2014/09/24 15:29:56, Avi wrote: > https://codereview.chromium.org/598923002/diff/1/content/child/runtime_features.cc > File content/child/runtime_features.cc (left): > > https://codereview.chromium.org/598923002/diff/1/content/child/runtime_features.cc#oldcode119 > ...
6 years, 2 months ago (2014-09-25 02:55:52 UTC) #4
MRV
PTAL https://codereview.chromium.org/598923002/diff/1/content/child/runtime_features.cc File content/child/runtime_features.cc (left): https://codereview.chromium.org/598923002/diff/1/content/child/runtime_features.cc#oldcode119 content/child/runtime_features.cc:119: if (!command_line.HasSwitch(switches::kEnableSpeechRecognition)) On 2014/09/24 15:29:56, Avi wrote: > ...
6 years, 2 months ago (2014-09-25 02:56:03 UTC) #5
Avi (use Gerrit)
lgtm
6 years, 2 months ago (2014-09-25 04:08:54 UTC) #6
MRV
On 2014/09/25 04:08:54, Avi wrote: > lgtm Thanks mr. avi, for LGTM
6 years, 2 months ago (2014-09-25 04:38:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598923002/20001
6 years, 2 months ago (2014-09-25 04:39:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3c93cab3253d003f2dcd448b5d6313d2b0b3d5a4
6 years, 2 months ago (2014-09-25 05:34:56 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6b8dda12a7d842517c5c4ee155cf48951e908a7f Cr-Commit-Position: refs/heads/master@{#296655}
6 years, 2 months ago (2014-09-25 05:35:37 UTC) #11
Michael van Ouwerkerk
On 2014/09/25 05:35:37, I haz the power (commit-bot) wrote: > Patchset 2 (id:??) landed as ...
6 years, 2 months ago (2014-09-25 11:32:47 UTC) #12
Michael van Ouwerkerk
6 years, 2 months ago (2014-09-25 11:33:11 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/602083002/ by mvanouwerkerk@chromium.org.

The reason for reverting is: I'm sorry, the ENABLE_SPEECH_RECOGNITION switch is
still used in the Chrome on
Android repo. I don't see (on the short term) another way of handling this than
not removing that switch. I'm going to revert this change..

Powered by Google App Engine
This is Rietveld 408576698