Change all V8 internal private symbols to be private own symbols.

Change all V8 internal private symbols to be private own symbols.

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24168

[Dmitry Lomov (no reviews), 2014-09-23 15:04:01]

PTAL. 
I have not removed private non-own symbols, and they are still exposed through
the API (v8::Private::New creates a private non-own symbol) to enable
experimenting with changes like these: https://codereview.chromium.org/555723002

[arv (Not doing code reviews), 2014-09-23 18:31:20]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2014-09-23 18:31:20]

https://codereview.chromium.org/598603002/diff/1/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/598603002/diff/1/src/messages.js#newcode1128
src/messages.js:1128: holder = %GetPrototype(holder);
Why are we using own private symbols here? It is clear that we want  non own
here.

[Dmitry Lomov (no reviews), 2014-09-24 06:07:40]

https://codereview.chromium.org/598603002/diff/1/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/598603002/diff/1/src/messages.js#newcode1128
src/messages.js:1128: holder = %GetPrototype(holder);
On 2014/09/23 18:31:20, arv wrote:
> Why are we using own private symbols here? It is clear that we want  non own
> here.

I just wanted to remove all non-own symbols from V8 code (in a built-ins, all
private symbols should be own, so that is is clear that GET_PRIVATE never walks
the proto chain).
I also wanted to kill private non-own in general, but then realized it is useful
for the API. 
Maybe I can continue using non-own here. I have no strong opinion.

[Yang, 2014-09-24 08:08:51]

On 2014/09/24 06:07:40, Dmitry Lomov (chromium) wrote:
> https://codereview.chromium.org/598603002/diff/1/src/messages.js
> File src/messages.js (right):
> 
> https://codereview.chromium.org/598603002/diff/1/src/messages.js#newcode1128
> src/messages.js:1128: holder = %GetPrototype(holder);
> On 2014/09/23 18:31:20, arv wrote:
> > Why are we using own private symbols here? It is clear that we want  non own
> > here.
> 
> I just wanted to remove all non-own symbols from V8 code (in a built-ins, all
> private symbols should be own, so that is is clear that GET_PRIVATE never
walks
> the proto chain).
> I also wanted to kill private non-own in general, but then realized it is
useful
> for the API. 
> Maybe I can continue using non-own here. I have no strong opinion.

LGTM.

[Dmitry Lomov (no reviews), 2014-09-24 08:09:35]

On 2014/09/24 06:07:40, Dmitry Lomov (chromium) wrote:
> https://codereview.chromium.org/598603002/diff/1/src/messages.js
> File src/messages.js (right):
> 
> https://codereview.chromium.org/598603002/diff/1/src/messages.js#newcode1128
> src/messages.js:1128: holder = %GetPrototype(holder);
> On 2014/09/23 18:31:20, arv wrote:
> > Why are we using own private symbols here? It is clear that we want  non own
> > here.
> 
> I just wanted to remove all non-own symbols from V8 code (in a built-ins, all
> private symbols should be own, so that is is clear that GET_PRIVATE never
walks
> the proto chain).
> I also wanted to kill private non-own in general, but then realized it is
useful
> for the API. 
> Maybe I can continue using non-own here. I have no strong opinion.

I thought about it further - since the way we walk the prototype chain and
install properties here is quite non-standard, we should keep the symbol private
own.

[Dmitry Lomov (no reviews), 2014-09-24 08:13:08]

Committed patchset #2 (id:20001) manually as 24168 (presubmit successful).