Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issue 598083002: Adding split view divider widget. (Closed)

Created:
6 years, 3 months ago by mfomitchev
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding split view divider widget. Adding split view divider widget which could be dragged to exit the split view. Resubmit of https://codereview.chromium.org/545393002 TBR=mukai@chromium.org BUG=403207, 408691 Committed: https://crrev.com/ef9025a5692b95eddc9cf2f3a7ebee38704b580a Cr-Commit-Position: refs/heads/master@{#296464}

Patch Set 1 #

Patch Set 2 : Fixing NOTREACHED() in a unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+755 lines, -105 lines) Patch
M athena/athena.gyp View 4 chunks +9 lines, -6 lines 0 comments Download
M athena/util/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A athena/util/drag_handle.h View 1 chunk +41 lines, -0 lines 0 comments Download
A athena/util/drag_handle.cc View 1 chunk +142 lines, -0 lines 0 comments Download
A athena/util/drag_handle_unittest.cc View 1 1 chunk +140 lines, -0 lines 0 comments Download
M athena/wm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M athena/wm/bezel_controller.h View 2 chunks +4 lines, -8 lines 0 comments Download
M athena/wm/bezel_controller.cc View 5 chunks +37 lines, -23 lines 0 comments Download
M athena/wm/split_view_controller.h View 6 chunks +63 lines, -16 lines 0 comments Download
M athena/wm/split_view_controller.cc View 1 10 chunks +313 lines, -50 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M athena/wm/window_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598083002/20001
6 years, 3 months ago (2014-09-24 17:10:36 UTC) #2
Jun Mukai
lgtm
6 years, 3 months ago (2014-09-24 17:13:46 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3b2e9e3603b8a7c2759f00cdd5b03a7b58fd41d8
6 years, 3 months ago (2014-09-24 18:04:40 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 18:05:44 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef9025a5692b95eddc9cf2f3a7ebee38704b580a
Cr-Commit-Position: refs/heads/master@{#296464}

Powered by Google App Engine
This is Rietveld 408576698