athena/wm/window_manager_unittest.cc - Issue 598083002: Adding split view divider widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/wm/window_manager_unittest.cc

Issue 598083002: Adding split view divider widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing NOTREACHED() in a unit test. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/wm/window_manager_unittest.cc

diff --git a/athena/wm/window_manager_unittest.cc b/athena/wm/window_manager_unittest.cc

index 9bcb5b8906a199207f9035e2f95fdbdb5d531a52..0723148fc62799c56590a97819d65047542b5246 100644

--- a/athena/wm/window_manager_unittest.cc

+++ b/athena/wm/window_manager_unittest.cc

@@ -318,8 +318,8 @@ TEST_F(WindowManagerTest, SplitModeActivationByShortcut) {

int width =

gfx::Screen::GetNativeScreen()->GetPrimaryDisplay().work_area().width();

- EXPECT_EQ(width / 2, w1->bounds().width());

- EXPECT_EQ(width / 2, w2->bounds().width());

+ EXPECT_EQ(w1->bounds().width(), w2->bounds().width());

+ EXPECT_GE(width / 2, w1->bounds().width());

// Toggle back to normal mode.

generator.PressKey(ui::VKEY_F6, ui::EF_CONTROL_DOWN);

« no previous file with comments | « athena/wm/window_manager_impl.cc ('k') | no next file » | no next file with comments »