[src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters

media/filters/renderer_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_RENDERER_IMPL_H_
 #define MEDIA_FILTERS_RENDERER_IMPL_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 133 matching lines @@
   BufferingState audio_buffering_state_;
   BufferingState video_buffering_state_;
 
   // Whether we've received the audio/video ended events.
   bool audio_ended_;
   bool video_ended_;
 
   bool underflow_disabled_for_testing_;
   bool clockless_video_playback_enabled_for_testing_;
 
+  base::WeakPtr<RendererImpl> weak_this_;
+
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<RendererImpl> weak_factory_;

[xhwang, 2014/09/29 16:34:02]

The order doesn't really matter here. But logically the original order is
correct. |weak_this_| will be invalid if |weak_factory_| is destructed.

-  base::WeakPtr<RendererImpl> weak_this_;
 
   DISALLOW_COPY_AND_ASSIGN(RendererImpl);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_RENDERER_IMPL_H_