[src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters

[src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters

Cleaning up weak_ptr_factory destruction order.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818
Committed: https://crrev.com/9b2e921f0b87db7da6533b3351d6afc9084db292
Cr-Commit-Position: refs/heads/master@{#298005}

[ARUNKK, 2014-09-29 12:42:03]

kulkarni.a@samsung.com changed reviewers:
+ ddorwin@chromium.org, xhwang@chromium.org

[ARUNKK, 2014-09-29 12:42:03]

ddorwin@chromium.org: Please review changes in 

xhwang@chromium.org: Please review changes in 

PTAL.

[xhwang, 2014-09-29 16:34:03]

https://codereview.chromium.org/598023004/diff/1/media/cast/test/fake_media_s...
File media/cast/test/fake_media_source.h (right):

https://codereview.chromium.org/598023004/diff/1/media/cast/test/fake_media_s...
media/cast/test/fake_media_source.h:145: 
Thanks for fixing this!

https://codereview.chromium.org/598023004/diff/1/media/filters/renderer_impl.h
File media/filters/renderer_impl.h (right):

https://codereview.chromium.org/598023004/diff/1/media/filters/renderer_impl....
media/filters/renderer_impl.h:157: base::WeakPtrFactory<RendererImpl>
weak_factory_;
The order doesn't really matter here. But logically the original order is
correct. |weak_this_| will be invalid if |weak_factory_| is destructed.

https://codereview.chromium.org/598023004/diff/1/media/mojo/services/mojo_ren...
File media/mojo/services/mojo_renderer_service.h (right):

https://codereview.chromium.org/598023004/diff/1/media/mojo/services/mojo_ren...
media/mojo/services/mojo_renderer_service.h:82:
base::WeakPtrFactory<MojoRendererService> weak_factory_;
ditto

[ARUNKK, 2014-09-30 03:52:04]

Thanks for review comments.
Review comments are incorporated.
PTAL.

https://codereview.chromium.org/598023004/diff/1/media/cast/test/fake_media_s...
File media/cast/test/fake_media_source.h (right):

https://codereview.chromium.org/598023004/diff/1/media/cast/test/fake_media_s...
media/cast/test/fake_media_source.h:145: 
On 2014/09/29 16:34:02, xhwang wrote:
> Thanks for fixing this!
WelCome :-)

[xhwang, 2014-10-03 04:00:10]

Please update your CL description to reflect what the current CL is doing.

[xhwang, 2014-10-03 04:03:06]

...otherwise LGTM. Thanks!

[ARUNKK, 2014-10-03 06:26:20]

The CQ bit was checked by kulkarni.a@samsung.com

[commit-bot: I haz the power, 2014-10-03 06:27:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/598023004/20001

[commit-bot: I haz the power, 2014-10-03 07:07:15]

Committed patchset #2 (id:20001) as 0d752de38ef84c3849af6b88ce4bd0a09fc38e14

[commit-bot: I haz the power, 2014-10-03 07:08:02]

Patchset 2 (id:??) landed as
https://crrev.com/9b2e921f0b87db7da6533b3351d6afc9084db292
Cr-Commit-Position: refs/heads/master@{#298005}

[xhwang, 2014-10-03 07:36:38]

Please make sure you address all comments before committing. The CL description
isn't correct in this case.

[xhwang, 2014-10-03 07:36:38]

Please make sure you address all comments before committing. The CL description
isn't correct in this case.