[src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters

media/cast/test/fake_media_source.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A fake media source that generates video and audio frames to a cast
 // sender.
 // This class can transcode a WebM file using FFmpeg. It can also
 // generate an animation and audio of fixed frequency.
 
 #ifndef MEDIA_CAST_TEST_FAKE_MEDIA_SOURCE_H_
@@ skipping 94 matching lines @@
   base::TickClock* const clock_;  // Not owned by this class.
 
   // Time when the stream starts.
   base::TimeTicks start_time_;
 
   // The following three members are used only for fake frames.
   int audio_frame_count_;  // Each audio frame is exactly 10ms.
   int video_frame_count_;
   scoped_ptr<TestAudioBusFactory> audio_bus_factory_;
 
-  // NOTE: Weak pointers must be invalidated before all other member variables.
-  base::WeakPtrFactory<FakeMediaSource> weak_factory_;
-
   base::MemoryMappedFile file_data_;
   scoped_ptr<InMemoryUrlProtocol> protocol_;
   scoped_ptr<FFmpegGlue> glue_;
   AVFormatContext* av_format_context_;
 
   int audio_stream_index_;
   AudioParameters audio_params_;
   double playback_rate_;
 
   int video_stream_index_;
   int video_frame_rate_numerator_;
   int video_frame_rate_denominator_;
 
   // These are used for audio resampling.
   scoped_ptr<media::MultiChannelResampler> audio_resampler_;
   scoped_ptr<media::AudioFifo> audio_fifo_;
   scoped_ptr<media::AudioBus> audio_fifo_input_bus_;
   media::AudioRendererAlgorithm audio_algo_;
 
   // Track the timestamp of audio sent to the receiver.
   scoped_ptr<media::AudioTimestampHelper> audio_sent_ts_;
 
   std::queue<scoped_refptr<VideoFrame> > video_frame_queue_;
   int64 video_first_pts_;
   bool video_first_pts_set_;
 
   std::queue<AudioBus*> audio_bus_queue_;
 
+  // NOTE: Weak pointers must be invalidated before all other member variables.
+  base::WeakPtrFactory<FakeMediaSource> weak_factory_;
+

[xhwang, 2014/09/29 16:34:02]

Thanks for fixing this!

[ARUNKK, 2014/09/30 03:52:04]

WelCome :-)

   DISALLOW_COPY_AND_ASSIGN(FakeMediaSource);
 };
 
 }  // namespace cast
 }  // namespace media
 
 #endif // MEDIA_CAST_TEST_FAKE_MEDIA_SOURCE_H_