Chromecast: adds Android switches for media playback.

Chromecast: adds Android switches for media playback.

Since Cast disables all user interaction, gesture requirement/infobar are
not useful.

The other flags are for protected content playback.

R=xhwang@chromium.org,byungchul@chromium.org
BUG=400876
Committed: https://crrev.com/c264a0567ee9417d1ff8d8dc61f3a79f2232ea06
Cr-Commit-Position: refs/heads/master@{#297113}

[gunsch, 2014-09-26 18:08:05]

On 2014/09/24 00:45:47, gunsch wrote:

ping?

[lcwu1, 2014-09-26 19:54:57]

lcwu@chromium.org changed reviewers:
+ lcwu@chromium.org

[lcwu1, 2014-09-26 19:54:58]

lgtm

[xhwang, 2014-09-26 21:49:37]

https://codereview.chromium.org/597813002/diff/1/chromecast/shell/browser/cas...
File chromecast/shell/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/597813002/diff/1/chromecast/shell/browser/cas...
chromecast/shell/browser/cast_browser_main_parts.cc:40: {
switches::kMediaDrmEnableNonCompositing, ""},
IIRIC, with this, we'll always use the full screen player. Is this expected?

https://codereview.chromium.org/597813002/diff/1/chromecast/shell/browser/cas...
chromecast/shell/browser/cast_browser_main_parts.cc:42: {
switches::kDisableInfobarForProtectedMediaIdentifier, ""},
The info bar is required for privacy reasons. Did you talk to privacy people to
make sure this is okay?

[gunsch, 2014-09-26 22:03:17]

https://codereview.chromium.org/597813002/diff/1/chromecast/shell/browser/cas...
File chromecast/shell/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/597813002/diff/1/chromecast/shell/browser/cas...
chromecast/shell/browser/cast_browser_main_parts.cc:40: {
switches::kMediaDrmEnableNonCompositing, ""},
On 2014/09/26 21:49:37, xhwang wrote:
> IIRIC, with this, we'll always use the full screen player. Is this expected?

We also build our Cast ATV build with VIDEO_HOLE. This is equivalent to:

https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/li...

https://codereview.chromium.org/597813002/diff/1/chromecast/shell/browser/cas...
chromecast/shell/browser/cast_browser_main_parts.cc:42: {
switches::kDisableInfobarForProtectedMediaIdentifier, ""},
On 2014/09/26 21:49:37, xhwang wrote:
> The info bar is required for privacy reasons. Did you talk to privacy people
to
> make sure this is okay?

Thanks for checking. Answer is yes (and double-checked just now with a few folks
to confirm). Cast on ATV is under the same privacy review that Chromecast went
through. Privacy review covered Chromecast also sending device-identifying
information for DRM content.

(Aside: we disable user interaction, so it'd be hard for the user to click on it
anyways :) )

[xhwang, 2014-09-27 05:24:07]

Thanks for the explanation. LGTM!

[gunsch, 2014-09-27 15:36:46]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-09-27 15:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597813002/1

[commit-bot: I haz the power, 2014-09-27 15:46:43]

Committed patchset #1 (id:1) as e46fd4b9c8148aeea5f45b95b1dbc585d85eba59

[commit-bot: I haz the power, 2014-09-27 15:47:12]

Patchset 1 (id:??) landed as
https://crrev.com/c264a0567ee9417d1ff8d8dc61f3a79f2232ea06
Cr-Commit-Position: refs/heads/master@{#297113}