Chromecast: adds Android switches for media playback.

chromecast/shell/browser/cast_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/shell/browser/cast_browser_main_parts.h"
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "chromecast/common/chromecast_config.h"
 #include "chromecast/metrics/cast_metrics_service_client.h"
 #include "chromecast/net/network_change_notifier_cast.h"
 #include "chromecast/net/network_change_notifier_factory_cast.h"
 #include "chromecast/service/cast_service.h"
 #include "chromecast/shell/browser/cast_browser_context.h"
 #include "chromecast/shell/browser/cast_browser_process.h"
 #include "chromecast/shell/browser/devtools/remote_debugging_server.h"
 #include "chromecast/shell/browser/url_request_context_factory.h"
 #include "chromecast/shell/browser/webui/webui_cast.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/content_switches.h"
+#include "media/base/media_switches.h"
 
 #if defined(OS_ANDROID)
 #include "net/android/network_change_notifier_factory_android.h"
 #endif  // defined(OS_ANDROID)
 
 namespace chromecast {
 namespace shell {
 
 namespace {
 
 struct DefaultCommandLineSwitch {
   const char* const switch_name;
   const char* const switch_value;
 };
 
 DefaultCommandLineSwitch g_default_switches[] = {
+#if defined(OS_ANDROID)
+  { switches::kMediaDrmEnableNonCompositing, ""},

[xhwang, 2014/09/26 21:49:37]

IIRIC, with this, we'll always use the full screen player. Is this expected?

[gunsch, 2014/09/26 22:03:17]

We also build our Cast ATV build with VIDEO_HOLE. This is equivalent to:

https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/li...

+  { switches::kEnableOverlayFullscreenVideo, ""},
+  { switches::kDisableInfobarForProtectedMediaIdentifier, ""},

[xhwang, 2014/09/26 21:49:37]

The info bar is required for privacy reasons. Did you talk to privacy people to
make sure this is okay?

[gunsch, 2014/09/26 22:03:17]

Thanks for checking. Answer is yes (and double-checked just now with a few folks
to confirm). Cast on ATV is under the same privacy review that Chromecast went
through. Privacy review covered Chromecast also sending device-identifying
information for DRM content.

(Aside: we disable user interaction, so it'd be hard for the user to click on it
anyways :) )

+  { switches::kDisableGestureRequirementForMediaPlayback, ""},
+#endif
   { switches::kDisableApplicationCache, "" },
   { switches::kDisablePlugins, "" },
   { NULL, NULL },  // Termination
 };
 
 void AddDefaultCommandLineSwitches(CommandLine* command_line) {
   int i = 0;
   while (g_default_switches[i].switch_name != NULL) {
     command_line->AppendSwitchASCII(
         std::string(g_default_switches[i].switch_name),
@@ skipping 69 matching lines @@
   return true;
 }
 
 void CastBrowserMainParts::PostMainMessageLoopRun() {
   cast_browser_process_->cast_service()->Stop();
   cast_browser_process_.reset();
 }
 
 }  // namespace shell
 }  // namespace chromecast