Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 59713010: Address some more valgrind issues (Closed)

Created:
7 years, 1 month ago by robertphillips
Modified:
7 years, 1 month ago
Reviewers:
jvanverth1, borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -21 lines) Patch
M gm/valgrind.supp View 1 chunk +13 lines, -4 lines 1 comment Download
M tests/BlurTest.cpp View 4 chunks +8 lines, -5 lines 1 comment Download
M tests/FontHostStreamTest.cpp View 2 chunks +2 lines, -1 line 1 comment Download
M tests/ImageFilterTest.cpp View 2 chunks +4 lines, -3 lines 1 comment Download
M tests/valgrind.supp View 1 chunk +13 lines, -4 lines 0 comments Download
M tools/valgrind.supp View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
https://codereview.chromium.org/59713010/diff/1/gm/valgrind.supp File gm/valgrind.supp (right): https://codereview.chromium.org/59713010/diff/1/gm/valgrind.supp#newcode69 gm/valgrind.supp:69: } This suppresses several instances of: 21,008 (20,992 direct, ...
7 years, 1 month ago (2013-11-14 14:21:41 UTC) #1
borenet
LGTM
7 years, 1 month ago (2013-11-14 14:42:49 UTC) #2
robertphillips
7 years, 1 month ago (2013-11-14 14:49:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12286 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698