tests/FontHostStreamTest.cpp - Issue 59713010: Address some more valgrind issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/FontHostStreamTest.cpp

Issue 59713010: Address some more valgrind issues (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/FontHostStreamTest.cpp

diff --git a/tests/FontHostStreamTest.cpp b/tests/FontHostStreamTest.cpp

index 30e469b4105b71857214e5dfc59620420b76027f..e15bd5a355ea0334a8138413cd31e95628a9830d 100644

--- a/tests/FontHostStreamTest.cpp

+++ b/tests/FontHostStreamTest.cpp

@@ -15,6 +15,7 @@

#include "SkPaint.h"

#include "SkPoint.h"

#include "SkRect.h"

+#include "SkStream.h"

#include "SkTypeface.h"

///////////////////////////////////////////////////////////////////////////////

@@ -99,7 +100,7 @@ static void test_fontHostStream(skiatest::Reporter* reporter) {

}

int ttcIndex;

robertphillips 2013/11/14 14:21:41 This addresses: 80 (32 direct, 48 indirect) bytes

- SkStream* fontData = origTypeface->openStream(&ttcIndex);

+ SkAutoTUnref<SkStream> fontData(origTypeface->openStream(&ttcIndex));

SkTypeface* streamTypeface = SkTypeface::CreateFromStream(fontData);

SkSafeUnref(paint.setTypeface(streamTypeface));

drawBG(&streamCanvas);