Address some more valgrind issues

tests/ImageFilterTest.cpp

 
 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "Test.h"
 #include "SkBicubicImageFilter.h"
@@ skipping 111 matching lines @@
             result.allocPixels();
 
             {
                 // This tests for :
                 // 1 ) location at (0,0,1)
                 SkPoint3 location(0, 0, SK_Scalar1);
                 // 2 ) location and target at same value
                 SkPoint3 target(location.fX, location.fY, location.fZ);
                 // 3 ) large negative specular exponent value
                 SkScalar specularExponent = SkFloatToScalar(-1000);
 

[robertphillips, 2013/11/14 14:21:41]

This addresses two problems like:

120 (112 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss
record 194 of 357
at 0x4C2B1C7: operator new(unsigned long) (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x448B34: ImageFilterTest::Test(skiatest::Reporter*)
(ImageFilterTest.cpp:149)
by 0x448E07: skiatest::ImageFilterTestClass::onRun(skiatest::Reporter*)
(ImageFilterTest.cpp:163)
by 0x49670A: skiatest::Test::run() (Test.cpp:109)
by 0x48FDA0: SkTestRunnable::run() (skia_test.cpp:155)
by 0x64BB65: SkThreadPool::Loop(void*) (SkThreadPool.cpp:97)
by 0x65697A: thread_start(void*) (SkThreadUtils_pthread.cpp:66)
by 0x4E39E99: start_thread (pthread_create.c:308)
by 0x6C71CCC: clone (clone.S:112)

+                SkAutoTUnref<SkImageFilter> bmSrc(new SkBitmapSource(bitmap));
                 SkPaint paint;
                 paint.setImageFilter(SkLightingImageFilter::CreateSpotLitSpecular(
                         location, target, specularExponent, SkFloatToScalar(180),
                         0xFFFFFFFF, SK_Scalar1, SK_Scalar1, SK_Scalar1,
-                        new SkBitmapSource(bitmap)))->unref();
+                        bmSrc))->unref();
                 SkCanvas canvas(result);
                 SkRect r = SkRect::MakeWH(SkIntToScalar(kBitmapSize),
                                           SkIntToScalar(kBitmapSize));
                 canvas.drawRect(r, paint);
             }
 
             {
                 // This tests for scale bringing width to 0
                 SkSize scale = SkSize::Make(SkFloatToScalar(-0.001f), SK_Scalar1);
+                SkAutoTUnref<SkImageFilter> bmSrc(new SkBitmapSource(bitmap));
                 SkAutoTUnref<SkBicubicImageFilter> bicubic(
-                    SkBicubicImageFilter::CreateMitchell(
-                        scale, new SkBitmapSource(bitmap)));
+                    SkBicubicImageFilter::CreateMitchell(scale, bmSrc));
                 SkBitmapDevice device(bitmap);
                 SkDeviceImageFilterProxy proxy(&device);
                 SkIPoint loc = SkIPoint::Make(0, 0);
                 // An empty input should early return and return false
                 REPORTER_ASSERT(reporter,
                     !bicubic->filterImage(&proxy, bitmap, SkMatrix::I(), &result, &loc));
             }
         }
     }
 };
 
 
 #include "TestClassDef.h"
 DEFINE_TESTCLASS("ImageFilterTest", ImageFilterTestClass, ImageFilterTest::Test)