LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt - Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt

Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html ('K') | « LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells-expected.txt ('k') | LayoutTests/platform/linux/tables/mozilla/bugs/bug133756-2-expected.png » ('j') | Source/core/rendering/RenderTableSection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt

diff --git a/LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt b/LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt

index 5f40e75b43aa3024f080b9ba0c1ea063448f8489..c8adca8140bc90b4569fc3dcd3ccfc61a43128b9 100644

--- a/LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt

+++ b/LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt

@@ -5,7 +5,7 @@ layer at (0,0) size 800x600

RenderBody {BODY} at (8,8) size 784x584

RenderTable {TABLE} at (0,0) size 784x84

RenderTableSection {TBODY} at (0,0) size 784x84

- RenderTableRow {TR} at (0,2) size 784x0

dsinclair 2014/10/15 21:37:41 Where does the 1px come from?

+ RenderTableRow {TR} at (0,2) size 784x1

RenderTableCell {TD} at (2,1) size 780x82 [r=0 c=0 rs=8190 cs=1]

RenderText {#text} at (1,1) size 770x79

text run at (1,1) width 644: "This test succeeds if it does not crash. We implemented a heuristic a while back to prevent giant rowspans. "