Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html

Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html
diff --git a/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html b/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html
new file mode 100644
index 0000000000000000000000000000000000000000..c7eec414ac9f96e8773350ac8c4f6d404f762768
--- /dev/null
+++ b/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html
@@ -0,0 +1,27 @@
+<html>
dsinclair 2014/10/15 21:37:41 Missing <!DOCTYPE html>
a.suchit 2014/12/03 13:09:13 With using DOCTYPE, Test case is behaving differen
+<head>
dsinclair 2014/10/15 21:37:41 Don't need html, head or body nodes.
a.suchit 2014/12/03 13:09:13 Removed HTML and HEAD node. BODY node is needed fo
+ <style>
+ table { border-collapse: collapse; }
+ td { border: 1px solid #000000; }
+ </style>
+ <script src="../../resources/check-layout.js"></script>
+</head>
+<body onload="checkLayout('tr')">
+ <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=396655">396655</a>. Tables with specific merge cell configuration render with extra height to tr elements.</h4>
+ <p>The middle tr, which has been merged over by two cells, should have a height of 1px, the difference in heights between cells that span one row and two rows.</p>
dsinclair 2014/10/15 21:37:41 This description is difficult to understand. How a
a.suchit 2014/12/03 13:09:13 Done.
+ <table style="width: 624px;">
+ <tbody>
+ <tr data-expected-height="32">
+ <td rowspan="2" style="height: 33px;"></td>
+ <td style="height: 32px;"></td>
+ </tr>
+ <tr data-expected-height="1">
+ <td rowspan="2" style="height: 33px;"></td>
+ </tr>
+ <tr data-expected-height="32">
+ <td style="height: 32px;"></td>
+ </tr>
+ </tbody>
+ </table>
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698