Source/core/rendering/RenderTableSection.h - Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTableSection.h

Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt ('K') | « LayoutTests/tables/mozilla/bugs/bug13169-expected.txt ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderTableSection.h

diff --git a/Source/core/rendering/RenderTableSection.h b/Source/core/rendering/RenderTableSection.h

index 8d67b733ad332a1e09e0c3f3c019d89291ffbe29..06260187813735d5f78ad2aeb6b4b3307e6d3afd 100644

--- a/Source/core/rendering/RenderTableSection.h

+++ b/Source/core/rendering/RenderTableSection.h

@@ -260,9 +260,8 @@ private:

void ensureRows(unsigned);

bool rowHasOnlySpanningCells(unsigned);

- unsigned calcRowHeightHavingOnlySpanningCells(unsigned);

- void updateRowsHeightHavingOnlySpanningCells(RenderTableCell*, struct SpanningRowsHeight&);

- bool isHeightNeededForRowHavingOnlySpanningCells(unsigned);

+ unsigned calcRowHeightHavingOnlySpanningCells(unsigned, int&, unsigned, unsigned&, Vector<int>&);

dsinclair 2014/10/15 21:37:42 I believe, in this case where it's ambiguous, it's

+ void updateRowsHeightHavingOnlySpanningCells(RenderTableCell*, struct SpanningRowsHeight&, unsigned&, Vector<int>&);

void populateSpanningRowsHeightFromCell(RenderTableCell*, struct SpanningRowsHeight&);

void distributeExtraRowSpanHeightToPercentRows(RenderTableCell*, int, int&, Vector<int>&);