LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html - Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html

Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells-expected.txt » ('j') | LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	dsinclair 2014/10/15 21:37:41 Missing <!DOCTYPE html> Missing <!DOCTYPE html> a.suchit 2014/12/03 13:09:13 With using DOCTYPE, Test case is behaving differen Show quoted text On 2014/10/15 21:37:41, dsinclair wrote: > Missing <!DOCTYPE html> With using DOCTYPE, Test case is behaving different. So DOCTYPE is not used here.
	2 <head>
	dsinclair 2014/10/15 21:37:41 Don't need html, head or body nodes. Don't need html, head or body nodes. a.suchit 2014/12/03 13:09:13 Removed HTML and HEAD node. BODY node is needed fo Show quoted text On 2014/10/15 21:37:41, dsinclair wrote: > Don't need html, head or body nodes. Removed HTML and HEAD node. BODY node is needed for checkLayout() on onload.
	3 <style>

	4 table { border-collapse: collapse; }

	5 td { border: 1px solid #000000; }

	6 </style>

	7 <script src="../../resources/check-layout.js"></script>

	8 </head>

	9 <body onload="checkLayout('tr')">

	10 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issu es/detail?id=396655">396655</a>. Tables with specific merge cell configuration r ender with extra height to tr elements.</h4>

	11 <p>The middle tr, which has been merged over by two cells, should have a hei ght of 1px, the difference in heights between cells that span one row and two ro ws.</p>
	dsinclair 2014/10/15 21:37:41 This description is difficult to understand. How a This description is difficult to understand. How about something like: We have the below table. Because cell A and cell D overlap in the second row, the height of the second row is the 1px difference between A and B and the 1px difference between C and D. \|-----\|-----\| \| A \| B \| \| \|-----\| \| \| \| \|-----\| \| \| C \| D \| \|-----\|-----\| a.suchit 2014/12/03 13:09:13 Done. Show quoted text On 2014/10/15 21:37:41, dsinclair wrote: > This description is difficult to understand. How about something like: > > We have the below table. Because cell A and cell D overlap in the second row, > the height of the > second row is the 1px difference between A and B and the 1px difference between > C and D. > \|-----\|-----\| > \| A \| B \| > \| \|-----\| > \| \| \| > \|-----\| \| > \| C \| D \| > \|-----\|-----\| Done.
	12 <table style="width: 624px;">

	13 <tbody>

	14 <tr data-expected-height="32">

	15 <td rowspan="2" style="height: 33px;"></td>

	16 <td style="height: 32px;"></td>

	17 </tr>

	18 <tr data-expected-height="1">

	19 <td rowspan="2" style="height: 33px;"></td>

	20 </tr>

	21 <tr data-expected-height="32">

	22 <td style="height: 32px;"></td>

	23 </tr>

	24 </tbody>

	25 </table>

	26 </body>

	27 </html>

OLD	NEW