Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 596703006: Revert IOSurface CoreAnimation simplifications on ccameron@'s advice. (Closed)

Created:
6 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, vsevik, devtools-reviews_chromium.org, jam, yurys, sievers+watch_chromium.org, jbauman+watch_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert IOSurface CoreAnimation simplifications on ccameron@'s advice. Contains: Revert "Workaround to prevent crashes when destroying CGL contexts" This reverts commit 282049cc52cd09cca07b8bd838f448174c7a87f5. Revert "Log erros while presenting an IOSurface to about:gpu" This reverts commit 090e36f056b103946e78aa69ba06de63ae78ccb6. Revert "Simplify IOSurface CoreAnimation code: Part 2" This reverts commit 672e23e9a1f1e11cb5f62c46ab8f687e3ca9d3da. Resolved conflicts: content/browser/compositor/io_surface_layer_mac.mm Fixed call ccameron@ pointed out in: https://codereview.chromium.org/490393002/diff/260001/content/browser/compositor/io_surface_layer_mac.mm#oldcode149 Build fixes for recent scoped_refptr changes. BUG=314190, 408986, 411782 R=piman@chromium.org TBR=ccameron@chromium.org,pfeldman@chromium.org Committed: https://crrev.com/8af59efe5582ea9f1b27fb029f3564523acb866d Cr-Commit-Position: refs/heads/master@{#296449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -394 lines) Patch
M content/browser/compositor/browser_compositor_view_private_mac.mm View 3 chunks +25 lines, -4 lines 0 comments Download
M content/browser/compositor/io_surface_layer_mac.h View 4 chunks +80 lines, -27 lines 0 comments Download
M content/browser/compositor/io_surface_layer_mac.mm View 5 chunks +187 lines, -360 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Ken Russell (switch to Gerrit)
Reviewers: do any of you want to check my work on this revert prescribed by ...
6 years, 3 months ago (2014-09-24 01:41:32 UTC) #2
piman
lgtm
6 years, 3 months ago (2014-09-24 03:23:00 UTC) #3
Ken Russell (switch to Gerrit)
Thanks. TBR'ing to pfeldman@ and CQ'ing.
6 years, 3 months ago (2014-09-24 17:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596703006/1
6 years, 3 months ago (2014-09-24 17:23:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as ceb4196fdc07a035522f28026239f66b1dcb597d
6 years, 3 months ago (2014-09-24 17:28:26 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8af59efe5582ea9f1b27fb029f3564523acb866d Cr-Commit-Position: refs/heads/master@{#296449}
6 years, 3 months ago (2014-09-24 17:29:24 UTC) #8
ccameron
6 years, 3 months ago (2014-09-24 19:53:47 UTC) #9
Message was sent while issue was closed.
lgtm after the fact

Powered by Google App Engine
This is Rietveld 408576698