Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596543002: Remove WebContentsObserver::ProvisionalChangeToMainFrameUrl and all the code supporting it. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
dcheng, davidben, nasko
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@redirprerender
Project:
chromium
Visibility:
Public.

Description

Remove WebContentsObserver::ProvisionalChangeToMainFrameUrl and all the code supporting it. BUG=78512, 407376 TEST=no change Committed: https://crrev.com/f43b759f4c912835e0b7e176b93e69d7ee56bc81 Cr-Commit-Position: refs/heads/master@{#296439}

Patch Set 1 #

Total comments: 2

Patch Set 2 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -131 lines) Patch
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/frame_host/navigator.h View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigator_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +0 lines, -16 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Avi (use Gerrit)
dcheng: ipc davidben: everything else This is for once https://codereview.chromium.org/565263005/ lands.
6 years, 3 months ago (2014-09-22 19:20:45 UTC) #2
davidben
lgtm once/if all the consumers are gone. https://codereview.chromium.org/596543002/diff/1/content/browser/frame_host/navigation_controller_impl_unittest.cc File content/browser/frame_host/navigation_controller_impl_unittest.cc (right): https://codereview.chromium.org/596543002/diff/1/content/browser/frame_host/navigation_controller_impl_unittest.cc#newcode1040 content/browser/frame_host/navigation_controller_impl_unittest.cc:1040: // Now ...
6 years, 3 months ago (2014-09-22 19:27:22 UTC) #3
Avi (use Gerrit)
https://codereview.chromium.org/596543002/diff/1/content/browser/frame_host/navigation_controller_impl_unittest.cc File content/browser/frame_host/navigation_controller_impl_unittest.cc (right): https://codereview.chromium.org/596543002/diff/1/content/browser/frame_host/navigation_controller_impl_unittest.cc#newcode1040 content/browser/frame_host/navigation_controller_impl_unittest.cc:1040: // Now the navigation redirects. (There is no longer ...
6 years, 3 months ago (2014-09-22 19:54:06 UTC) #4
nasko
IPC LGTM
6 years, 2 months ago (2014-09-23 14:20:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596543002/20001
6 years, 2 months ago (2014-09-24 15:50:25 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 558a0b0a0152ac1478f0f186ef5207f6f175b536
6 years, 2 months ago (2014-09-24 16:42:59 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 16:43:48 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f43b759f4c912835e0b7e176b93e69d7ee56bc81
Cr-Commit-Position: refs/heads/master@{#296439}

Powered by Google App Engine
This is Rietveld 408576698