Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 596543002: Remove WebContentsObserver::ProvisionalChangeToMainFrameUrl and all the code supporting it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@redirprerender
Patch Set: done Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 RenderFrameHostImpl* render_frame_host, 51 RenderFrameHostImpl* render_frame_host,
52 const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {}; 52 const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {};
53 53
54 // The RenderFrameHostImpl has failed to load the document. 54 // The RenderFrameHostImpl has failed to load the document.
55 virtual void DidFailLoadWithError( 55 virtual void DidFailLoadWithError(
56 RenderFrameHostImpl* render_frame_host, 56 RenderFrameHostImpl* render_frame_host,
57 const GURL& url, 57 const GURL& url,
58 int error_code, 58 int error_code,
59 const base::string16& error_description) {} 59 const base::string16& error_description) {}
60 60
61 // The RenderFrameHostImpl processed a redirect during a provisional load.
62 //
63 // TODO(creis): Remove this method and have the pre-rendering code listen to
64 // WebContentsObserver::DidGetRedirectForResourceRequest instead.
65 // See http://crbug.com/78512.
66 virtual void DidRedirectProvisionalLoad(
67 RenderFrameHostImpl* render_frame_host,
68 int32 page_id,
69 const GURL& source_url,
70 const GURL& target_url) {}
71
72 // The RenderFrameHostImpl has committed a navigation. 61 // The RenderFrameHostImpl has committed a navigation.
73 virtual void DidNavigate( 62 virtual void DidNavigate(
74 RenderFrameHostImpl* render_frame_host, 63 RenderFrameHostImpl* render_frame_host,
75 const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {} 64 const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {}
76 65
77 // Called by the NavigationController to cause the Navigator to navigate 66 // Called by the NavigationController to cause the Navigator to navigate
78 // to the current pending entry. The NavigationController should be called 67 // to the current pending entry. The NavigationController should be called
79 // back with RendererDidNavigate on success or DiscardPendingEntry on failure. 68 // back with RendererDidNavigate on success or DiscardPendingEntry on failure.
80 // The callbacks can be inside of this function, or at some future time. 69 // The callbacks can be inside of this function, or at some future time.
81 // 70 //
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 const NavigationBeforeCommitInfo& info) {}; 116 const NavigationBeforeCommitInfo& info) {};
128 117
129 protected: 118 protected:
130 friend class base::RefCounted<Navigator>; 119 friend class base::RefCounted<Navigator>;
131 virtual ~Navigator() {} 120 virtual ~Navigator() {}
132 }; 121 };
133 122
134 } // namespace content 123 } // namespace content
135 124
136 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 125 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/navigator_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698