content/browser/frame_host/navigator.h - Issue 596543002: Remove WebContentsObserver::ProvisionalChangeToMainFrameUrl and all the code supporting it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator.h

Issue 596543002: Remove WebContentsObserver::ProvisionalChangeToMainFrameUrl and all the code supporting it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@redirprerender

Patch Set: done Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/navigator_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator.h

diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h

index af8e71ec151a6eb8f33b8e916dc8b3c380096fa3..e25671d0f1a42f046f5db8108755b1623df27e71 100644

--- a/content/browser/frame_host/navigator.h

+++ b/content/browser/frame_host/navigator.h

@@ -58,17 +58,6 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {

int error_code,

const base::string16& error_description) {}

- // The RenderFrameHostImpl processed a redirect during a provisional load.

- //

- // TODO(creis): Remove this method and have the pre-rendering code listen to

- // WebContentsObserver::DidGetRedirectForResourceRequest instead.

- // See http://crbug.com/78512.

- virtual void DidRedirectProvisionalLoad(

- RenderFrameHostImpl* render_frame_host,

- int32 page_id,

- const GURL& source_url,

- const GURL& target_url) {}

// The RenderFrameHostImpl has committed a navigation.

virtual void DidNavigate(

RenderFrameHostImpl* render_frame_host,