Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 59613010: Fix propagation of clip-path and border-radius clipping to child layers (Closed)

Created:
7 years, 1 month ago by Justin Novosad
Modified:
7 years, 1 month ago
CC:
blink-reviews, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, rosca
Visibility:
Public.

Description

Fix propagation of clip-path and border-radius clipping to child layers RenderLayer clips of any shape other than a rectangle were not properly propagated to child render layers, which is required for overflow clipping and for CSS clip-path. This patch resolves the problem by recursively applying clips that propagate from DOM ancestors of the current render layer. BUG=237100

Patch Set 1 #

Patch Set 2 : fix for mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -41 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-css-border-radius-container.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-css-clip-path-container.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-css-clip-path-container-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-css-clip-path-intersection.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-css-clip-path-intersection-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-css-clip-path-nested-container.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-css-clip-path-nested-container-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 6 chunks +10 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 7 chunks +95 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Justin Novosad
PTAL
7 years, 1 month ago (2013-11-19 22:02:40 UTC) #1
Justin Novosad
Reviewers: I just became aware of this other patch that is up for review. It ...
7 years, 1 month ago (2013-11-20 00:27:42 UTC) #2
Justin Novosad
7 years, 1 month ago (2013-11-20 16:13:22 UTC) #3
On 2013/11/20 00:27:42, junov wrote:
> Reviewers: I just became aware of this other patch that is up for review. It
has
> an overlapping purpose: https://codereview.chromium.org/19954010/

Cancelling this review in favor of the other propsed CL

Powered by Google App Engine
This is Rietveld 408576698