Source/core/rendering/CompositedLayerMapping.cpp - Issue 59613010: Fix propagation of clip-path and border-radius clipping to child layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/CompositedLayerMapping.cpp

Issue 59613010: Fix propagation of clip-path and border-radius clipping to child layers (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix for mac build Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-css-clip-path-nested-container-expected.html ('k') | Source/core/rendering/RenderLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/CompositedLayerMapping.cpp

diff --git a/Source/core/rendering/CompositedLayerMapping.cpp b/Source/core/rendering/CompositedLayerMapping.cpp

index 712f29ef5422befe02dd49a23fa0a8935c6bf0a7..bb25b61ffecaf93d09a14fdb31342eaac3bbc5d5 100644

--- a/Source/core/rendering/CompositedLayerMapping.cpp

+++ b/Source/core/rendering/CompositedLayerMapping.cpp

@@ -464,7 +464,8 @@ bool CompositedLayerMapping::updateGraphicsLayerConfiguration()

if (updateMaskLayer(renderer->hasMask()))

m_graphicsLayer->setMaskLayer(m_maskLayer.get());

- bool needsChildClippingMask = (renderer->style()->hasBorderRadius() || renderer->style()->clipPath()) && isAcceleratedContents(renderer);

+ bool needsChildClippingMask = (renderer->style()->hasBorderRadius() || m_owningLayer->hasComplexClippedAncestor()) && isAcceleratedContents(renderer);

if (updateClippingMaskLayers(needsChildClippingMask))

m_graphicsLayer->setContentsClippingMaskLayer(m_childClippingMaskLayer.get());

« no previous file with comments | « LayoutTests/fast/canvas/canvas-css-clip-path-nested-container-expected.html ('k') | Source/core/rendering/RenderLayer.h » ('j') | no next file with comments »