Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 595713002: Move local frame-only methods out of WebFrame. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
dcheng, abarth-chromium, blink-reviews, dglazkov+blink, jamesr, lushnikov, mkwst+moarreviews_chromium.org, mlamouri (slow - plz ping), Zeeshan Qureshi
Project:
blink
Visibility:
Public.

Description

Move local frame-only methods out of WebFrame. This CL is just cleaning up new methods that were added after the OOPI work began. BUG=416656, 416658, 416659 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182568

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reorder and newlines #

Patch Set 3 : One more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -102 lines) Patch
M Source/web/WebFrame.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 5 chunks +53 lines, -43 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebFrame.h View 3 chunks +0 lines, -25 lines 0 comments Download
M public/web/WebLocalFrame.h View 1 2 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
dcheng
This is dependent on a Chrome-side patch I'm working on--unfortunately, orientation changes are already calling ...
6 years, 3 months ago (2014-09-23 00:25:03 UTC) #2
dcheng
(FYI corresponding Chrome change is https://codereview.chromium.org/596623002)
6 years, 3 months ago (2014-09-23 00:30:43 UTC) #3
jamesr
lgtm https://codereview.chromium.org/595713002/diff/1/public/web/WebLocalFrame.h File public/web/WebLocalFrame.h (left): https://codereview.chromium.org/595713002/diff/1/public/web/WebLocalFrame.h#oldcode41 public/web/WebLocalFrame.h:41: i think 2 blank lines between sections is ...
6 years, 3 months ago (2014-09-23 02:39:16 UTC) #4
dcheng
https://codereview.chromium.org/595713002/diff/1/public/web/WebLocalFrame.h File public/web/WebLocalFrame.h (left): https://codereview.chromium.org/595713002/diff/1/public/web/WebLocalFrame.h#oldcode41 public/web/WebLocalFrame.h:41: On 2014/09/23 at 02:39:16, jamesr wrote: > i think ...
6 years, 3 months ago (2014-09-23 03:04:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595713002/20001
6 years, 3 months ago (2014-09-23 06:30:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/59361)
6 years, 3 months ago (2014-09-23 06:43:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595713002/20001
6 years, 3 months ago (2014-09-24 04:39:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/11439)
6 years, 3 months ago (2014-09-24 04:54:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595713002/40001
6 years, 3 months ago (2014-09-24 05:29:07 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 07:24:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 182568

Powered by Google App Engine
This is Rietveld 408576698