Fix orientation change callbacks to go through WebLocalFrame.

Fix orientation change callbacks to go through WebLocalFrame.

Remote frames can't script, so it never makes sense to dispatch
orientation change events at remote frames. Also cleans up some method
declarations to have named parameters, to match Chromium style.

BUG=416658
Committed: https://crrev.com/ed9f6c1cd0d7852e2108262cb1f19f69a8437160
Cr-Commit-Position: refs/heads/master@{#296148}

[dcheng, 2014-09-23 00:30:26]

dcheng@chromium.org changed reviewers:
+ jam@chromium.org

[dcheng, 2014-09-23 00:30:27]

This blocks a cleanup change in Blink: https://codereview.chromium.org/595713002

[jam, 2014-09-23 05:17:14]

lgtm with nits

https://codereview.chromium.org/596623002/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/596623002/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:3131:
DCHECK(webview()->mainFrame()->isWebLocalFrame());
nit: no need, if it's null the next line will be just as useful of a signal

https://codereview.chromium.org/596623002/diff/1/content/shell/renderer/webki...
File content/shell/renderer/webkit_test_runner.cc (right):

https://codereview.chromium.org/596623002/diff/1/content/shell/renderer/webki...
content/shell/renderer/webkit_test_runner.cc:228:
DCHECK(render_view()->GetWebView()->mainFrame()->isWebLocalFrame());
ditto

[dcheng, 2014-09-23 05:24:34]

https://codereview.chromium.org/596623002/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/596623002/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:3131:
DCHECK(webview()->mainFrame()->isWebLocalFrame());
On 2014/09/23 05:17:13, jam wrote:
> nit: no need, if it's null the next line will be just as useful of a signal

Done.

https://codereview.chromium.org/596623002/diff/1/content/shell/renderer/webki...
File content/shell/renderer/webkit_test_runner.cc (right):

https://codereview.chromium.org/596623002/diff/1/content/shell/renderer/webki...
content/shell/renderer/webkit_test_runner.cc:228:
DCHECK(render_view()->GetWebView()->mainFrame()->isWebLocalFrame());
On 2014/09/23 05:17:14, jam wrote:
> ditto

Done.

[dcheng, 2014-09-23 05:24:39]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-09-23 05:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596623002/20001

[commit-bot: I haz the power, 2014-09-23 06:13:20]

Committed patchset #2 (id:20001) as 66e90d639bc0a078279e17faf7a104ecd6260541

[commit-bot: I haz the power, 2014-09-23 06:13:57]

Patchset 2 (id:??) landed as
https://crrev.com/ed9f6c1cd0d7852e2108262cb1f19f69a8437160
Cr-Commit-Position: refs/heads/master@{#296148}