Source/web/tests/WebFrameTest.cpp - Issue 595713002: Move local frame-only methods out of WebFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 595713002: Move local frame-only methods out of WebFrame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: One more Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 2d836ae64efb30d8d764cc3a251f32354adf4472..d755ccea9380f42b943ef368008915905849c2d9 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -4095,7 +4095,7 @@ protected:

const WebSelectionBound* selectEnd = m_fakeSelectionLayerTreeView.end();

v8::HandleScope handleScope(v8::Isolate::GetCurrent());

- v8::Handle<v8::Value> result = m_webViewHelper.webView()->mainFrame()->executeScriptAndReturnValueForTests(WebScriptSource("expectedResult"));

+ v8::Handle<v8::Value> result = m_webViewHelper.webView()->mainFrame()->toWebLocalFrame()->executeScriptAndReturnValueForTests(WebScriptSource("expectedResult"));

if (result.IsEmpty() || (*result)->IsUndefined()) {

EXPECT_FALSE(selectStart);

EXPECT_FALSE(selectEnd);

« no previous file with comments | « Source/web/WebRemoteFrameImpl.cpp ('k') | public/web/WebFrame.h » ('j') | no next file with comments »