Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 595093002: Handle "inplace" ops and unary ops w/ assembler (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Handle "inplace" ops and unary ops w/ assembler Extend the bswap test to have a case which will exhibit a bit of register pressure to test register encoding more (at first wasn't sure if it was 0xC8 + reg or 0xC8 | reg... but it should be the same since there's only 0-7 for regs). BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3b43b8968fff7ec287967a2f549c404bfb89d898

Patch Set 1 #

Patch Set 2 : handle movd #

Patch Set 3 : formatting #

Patch Set 4 : convert as bytereg just in case #

Patch Set 5 : make helper for converting byte reg/non-byte #

Patch Set 6 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -75 lines) Patch
M crosstest/test_bitmanip.h View 1 chunk +3 lines, -1 line 0 comments Download
M crosstest/test_bitmanip.cpp View 1 chunk +13 lines, -1 line 0 comments Download
M crosstest/test_bitmanip_main.cpp View 1 chunk +24 lines, -13 lines 0 comments Download
M src/IceInstX8632.h View 1 2 9 chunks +55 lines, -29 lines 0 comments Download
M src/IceInstX8632.cpp View 1 2 3 4 5 4 chunks +133 lines, -20 lines 0 comments Download
M src/IceRegistersX8632.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M src/assembler_ia32.h View 1 2 4 chunks +31 lines, -4 lines 0 comments Download
M src/assembler_ia32.cpp View 1 2 5 chunks +82 lines, -7 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-ops.ll View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jvoung (off chromium)
6 years, 2 months ago (2014-09-24 04:29:55 UTC) #2
Jim Stichnoth
LGTM. When the dust settles, we should try to do something about all the static_casts.
6 years, 2 months ago (2014-09-24 15:40:28 UTC) #3
jvoung (off chromium)
On 2014/09/24 15:40:28, stichnot wrote: > LGTM. > > When the dust settles, we should ...
6 years, 2 months ago (2014-09-24 18:15:58 UTC) #4
Jim Stichnoth
On 2014/09/24 18:15:58, jvoung wrote: > On 2014/09/24 15:40:28, stichnot wrote: > > LGTM. > ...
6 years, 2 months ago (2014-09-24 20:22:01 UTC) #5
jvoung (off chromium)
6 years, 2 months ago (2014-09-24 20:32:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as 3b43b89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698