mojo/apps/js/main.cc - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/main.cc

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Turn static variables into pointers and remove v8 init in net Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/apps/js/main.cc

diff --git a/mojo/apps/js/main.cc b/mojo/apps/js/main.cc

index 5ecf47d5d061ffb049f35c4d7a2df9ab3e1a2bb3..e57b89bc865270f929d85387f3ed81df993f0b2d 100644

--- a/mojo/apps/js/main.cc

+++ b/mojo/apps/js/main.cc

@@ -3,12 +3,18 @@

// found in the LICENSE file.

#include "base/i18n/icu_util.h"

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+#include "gin/public/isolate_holder.h"

+#endif // V8_USE_EXTERNAL_STARTUP_DATA

#include "mojo/application/application_runner_chromium.h"

#include "mojo/apps/js/application_delegate_impl.h"

#include "mojo/public/c/system/main.h"

MojoResult MojoMain(MojoHandle shell_handle) {

base::i18n::InitializeICU();

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+ gin::IsolateHolder::LoadV8Snapshot();

+#endif // V8_USE_EXTERNAL_STARTUP_DATA

rmcilroy 2014/09/23 14:05:40 Ditto - move this to the call to be below the call

baixo 2014/09/23 19:30:30 Same as before.

mojo::ApplicationRunnerChromium runner(

new mojo::apps::ApplicationDelegateImpl());

return runner.Run(shell_handle);

« gin/shell/gin_main.cc ('K') | « gin/shell/gin_main.cc ('k') | no next file » | no next file with comments »