mojo/apps/js/main.cc - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/apps/js/main.cc

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Turn static variables into pointers and remove v8 init in net Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/i18n/icu_util.h"	5 #include "base/i18n/icu_util.h"

	6 #ifdef V8_USE_EXTERNAL_STARTUP_DATA

	7 #include "gin/public/isolate_holder.h"

	8 #endif // V8_USE_EXTERNAL_STARTUP_DATA

6 #include "mojo/application/application_runner_chromium.h"	9 #include "mojo/application/application_runner_chromium.h"

7 #include "mojo/apps/js/application_delegate_impl.h"	10 #include "mojo/apps/js/application_delegate_impl.h"

8 #include "mojo/public/c/system/main.h"	11 #include "mojo/public/c/system/main.h"

9	12

10 MojoResult MojoMain(MojoHandle shell_handle) {	13 MojoResult MojoMain(MojoHandle shell_handle) {

11 base::i18n::InitializeICU();	14 base::i18n::InitializeICU();

	15 #ifdef V8_USE_EXTERNAL_STARTUP_DATA

	16 gin::IsolateHolder::LoadV8Snapshot();

	17 #endif // V8_USE_EXTERNAL_STARTUP_DATA
	rmcilroy 2014/09/23 14:05:40 Ditto - move this to the call to be below the call Ditto - move this to the call to be below the call to gin::IsolateHolder::LoadV8Snapshot() in mojo. baixo 2014/09/23 19:30:30 Same as before. Show quoted text On 2014/09/23 14:05:40, rmcilroy wrote: > Ditto - move this to the call to be below the call to > gin::IsolateHolder::LoadV8Snapshot() in mojo. Same as before.
12 mojo::ApplicationRunnerChromium runner(	18 mojo::ApplicationRunnerChromium runner(

13 new mojo::apps::ApplicationDelegateImpl());	19 new mojo::apps::ApplicationDelegateImpl());

14 return runner.Run(shell_handle);	20 return runner.Run(shell_handle);

15 }	21 }

OLD	NEW

« gin/shell/gin_main.cc ('K') | « gin/shell/gin_main.cc ('k') | no next file » | no next file with comments »