Infrastructure for reading V8's initial snapshot from external files

gin/shell/gin_main.cc

Index: gin/shell/gin_main.cc
diff --git a/gin/shell/gin_main.cc b/gin/shell/gin_main.cc
index aa9f2b5ea93625067949cad9f40847da0d0caa72..574c8b528ebc5d8def4c5fb0a12787385a3a2c64 100644
--- a/gin/shell/gin_main.cc
+++ b/gin/shell/gin_main.cc
@@ -61,6 +61,9 @@ int main(int argc, char** argv) {
   base::AtExitManager at_exit;
   CommandLine::Init(argc, argv);
   base::i18n::InitializeICU();
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+  gin::IsolateHolder::LoadV8Snapshot();
+#endif // V8_USE_EXTERNAL_STARTUP_DATA

[rmcilroy, 2014/09/23 14:05:40]

nit - move this block to be below gin::IsolateHolder::Initialize (and search for
gin::IsolateHolder::Initialize elsewhere in the codebase and add the
gin::IsolateHolder::LoadV8Snapshot(); below those calls, which should fix the
other test failures you are seeing (and avoid the gin dependency issues you had
before)..

[baixo, 2014/09/23 19:30:30]

This can't be moved below because gin::IsolateHolder::Initialize depends on
this.

Did add a call to gin::IsolateHolder::LoadV8Snapshot() *before* every call to
gin::IsolateHolder::Initialize, except for net/proxy/proxy_resolver_v8.cc, as
this is not a test and I don't know whether the call would be performed by a
process that can or cannot read from the file system.

Didn't add a call to mojo/apps/js/js_app.cc either, but the one in
mojo/apps/js/main.cc will probably take care of that.

 
   gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
                                  gin::ArrayBufferAllocator::SharedInstance());