Infrastructure for reading V8's initial snapshot from external files

gin/shell/gin_main.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/at_exit.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/i18n/icu_util.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 43 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(GinShellRunnerDelegate);
 };
 
 }  // namespace
 }  // namespace gin
 
 int main(int argc, char** argv) {
   base::AtExitManager at_exit;
   CommandLine::Init(argc, argv);
   base::i18n::InitializeICU();
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+  gin::IsolateHolder::LoadV8Snapshot();
+#endif // V8_USE_EXTERNAL_STARTUP_DATA

[rmcilroy, 2014/09/23 14:05:40]

nit - move this block to be below gin::IsolateHolder::Initialize (and search for
gin::IsolateHolder::Initialize elsewhere in the codebase and add the
gin::IsolateHolder::LoadV8Snapshot(); below those calls, which should fix the
other test failures you are seeing (and avoid the gin dependency issues you had
before)..

[baixo, 2014/09/23 19:30:30]

This can't be moved below because gin::IsolateHolder::Initialize depends on
this.

Did add a call to gin::IsolateHolder::LoadV8Snapshot() *before* every call to
gin::IsolateHolder::Initialize, except for net/proxy/proxy_resolver_v8.cc, as
this is not a test and I don't know whether the call would be performed by a
process that can or cannot read from the file system.

Didn't add a call to mojo/apps/js/js_app.cc either, but the one in
mojo/apps/js/main.cc will probably take care of that.

 
   gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
                                  gin::ArrayBufferAllocator::SharedInstance());
   gin::IsolateHolder instance;
 
   base::MessageLoop message_loop;
 
   gin::GinShellRunnerDelegate delegate;
   gin::ShellRunner runner(&delegate, instance.isolate());
 
   {
     gin::Runner::Scope scope(&runner);
     v8::V8::SetCaptureStackTraceForUncaughtExceptions(true);
   }
 
   CommandLine::StringVector args = CommandLine::ForCurrentProcess()->GetArgs();
   for (CommandLine::StringVector::const_iterator it = args.begin();
        it != args.end(); ++it) {
     base::MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
         gin::Run, runner.GetWeakPtr(), base::FilePath(*it)));
   }
 
   message_loop.RunUntilIdle();
   return 0;
 }