[GCM] Passing GCMClient::AccountTokenInfo list to GCMDriver

[GCM] Passing GCMClient::AccountTokenInfo list to GCMDriver

* Making sure GCMAccountTracker is only depenedent on the GCMDriver
* Replacing GCMDesktopDriver.SetAccountsForCheckin with
  virtual GCMDesktop.SetAccountTokens
* Producing a vector of AccountTokenInfo in GCMAccountTracker

BUG=374969
R=jianli@chromium.org

Committed: https://crrev.com/58b9dfcdec72d65fe130738df1ba372fcc720824
Cr-Commit-Position: refs/heads/master@{#297190}

[fgorski, 2014-09-24 22:22:41]

PTAL.

Patch is dependent on the previous (https://codereview.chromium.org/600053002/)
hence the failure of bots.

[jianli, 2014-09-25 20:26:46]

https://codereview.chromium.org/594383003/diff/40001/chrome/browser/services/...
File chrome/browser/services/gcm/gcm_profile_service.cc (right):

https://codereview.chromium.org/594383003/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/gcm_profile_service.cc:7: #include <map>
Please update this to vector.

https://codereview.chromium.org/594383003/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/gcm_profile_service.cc:56: // |account_tokens| maps
email addresses to OAuth2 access tokens.
Please update the comment here.

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver.h (right):

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver.h:8: #include <map>
This could be removed.

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver.h:121: // Sets a list of accounts with OAuth2
tokens available in the system.
It is a bit confusing by "setting a list of accounts ...". The people who read
the comment do not know what "setting" is meant? Could you please illustrate it?

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_android.cc (right):

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_android.cc:142: void
FakeGCMDriver::SetAccountTokens(
I do not think this will compile.

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_android.cc:144: }
Please add either "NOTIMPLEMENTED()" or comment "Nothing to do".

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_desktop.cc (right):

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_desktop.cc:621: std::map<std::string,
std::string> account_token_map;
I think we should also pass std::vector to IO thread and then to GCMClient that
will decide if it needs to convert from std::vector to std::map.

[fgorski, 2014-09-26 22:51:42]

Updated based on CR. So far try bots look promising.

https://codereview.chromium.org/594383003/diff/40001/chrome/browser/services/...
File chrome/browser/services/gcm/gcm_profile_service.cc (right):

https://codereview.chromium.org/594383003/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/gcm_profile_service.cc:7: #include <map>
On 2014/09/25 20:26:45, jianli wrote:
> Please update this to vector.

Done.

https://codereview.chromium.org/594383003/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/gcm_profile_service.cc:56: // |account_tokens| maps
email addresses to OAuth2 access tokens.
On 2014/09/25 20:26:45, jianli wrote:
> Please update the comment here.

Done.

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver.h (right):

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver.h:8: #include <map>
On 2014/09/25 20:26:45, jianli wrote:
> This could be removed.

It is still used in few places.

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver.h:121: // Sets a list of accounts with OAuth2
tokens available in the system.
On 2014/09/25 20:26:45, jianli wrote:
> It is a bit confusing by "setting a list of accounts ...". The people who read
> the comment do not know what "setting" is meant? Could you please illustrate
it?

Done.

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_android.cc (right):

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_android.cc:142: void
FakeGCMDriver::SetAccountTokens(
On 2014/09/25 20:26:45, jianli wrote:
> I do not think this will compile.

Done.

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_android.cc:144: }
On 2014/09/25 20:26:45, jianli wrote:
> Please add either "NOTIMPLEMENTED()" or comment "Nothing to do".

Done. And added to the other account handling methods.

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_driver_desktop.cc (right):

https://codereview.chromium.org/594383003/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_driver_desktop.cc:621: std::map<std::string,
std::string> account_token_map;
On 2014/09/25 20:26:45, jianli wrote:
> I think we should also pass std::vector to IO thread and then to GCMClient
that
> will decide if it needs to convert from std::vector to std::map.

Done.

[jianli, 2014-09-26 23:36:38]

lgtm

[fgorski, 2014-09-29 16:41:24]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-09-29 16:42:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/594383003/80001

[commit-bot: I haz the power, 2014-09-29 16:46:27]

Committed patchset #5 (id:80001) as dfc7107315a0ee64941076debf9af664b84aa7ab

[commit-bot: I haz the power, 2014-09-29 16:47:05]

Patchset 5 (id:??) landed as
https://crrev.com/58b9dfcdec72d65fe130738df1ba372fcc720824
Cr-Commit-Position: refs/heads/master@{#297190}