components/gcm_driver/gcm_account_mapper.h - Issue 594383003: [GCM] Passing GCMClient::AccountTokenInfo list to GCMDriver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_account_mapper.h

Issue 594383003: [GCM] Passing GCMClient::AccountTokenInfo list to GCMDriver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@account-mapper

Patch Set: Addressing CR comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/gcm_account_mapper.h

diff --git a/components/gcm_driver/gcm_account_mapper.h b/components/gcm_driver/gcm_account_mapper.h

index 524adbdd3554546ddaab6f09fcb2e9cfd9c0b148..fd1ca640b3773f89298a234c159fd485a7920ecc 100644

--- a/components/gcm_driver/gcm_account_mapper.h

+++ b/components/gcm_driver/gcm_account_mapper.h

@@ -37,7 +37,7 @@ class GCMAccountMapper : public GCMAppHandler {

// Called by AccountTracker, when a new list of account tokens is available.

// This will cause a refresh of account mappings and sending updates to GCM.

void SetAccountTokens(

- const std::vector<GCMClient::AccountTokenInfo> account_tokens);

+ const std::vector<GCMClient::AccountTokenInfo>& account_tokens);

// Implementation of GCMAppHandler:

virtual void ShutdownHandler() OVERRIDE;

« no previous file with comments | « components/gcm_driver/fake_gcm_driver.cc ('k') | components/gcm_driver/gcm_account_mapper.cc » ('j') | no next file with comments »