Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: components/gcm_driver/gcm_driver_android.cc

Issue 594383003: [GCM] Passing GCMClient::AccountTokenInfo list to GCMDriver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@account-mapper
Patch Set: Rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/gcm_driver/gcm_driver_android.h" 5 #include "components/gcm_driver/gcm_driver_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_array.h" 8 #include "base/android/jni_array.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 const GetGCMStatisticsCallback& callback, 132 const GetGCMStatisticsCallback& callback,
133 bool clear_logs) { 133 bool clear_logs) {
134 NOTIMPLEMENTED(); 134 NOTIMPLEMENTED();
135 } 135 }
136 136
137 void GCMDriverAndroid::SetGCMRecording(const GetGCMStatisticsCallback& callback, 137 void GCMDriverAndroid::SetGCMRecording(const GetGCMStatisticsCallback& callback,
138 bool recording) { 138 bool recording) {
139 NOTIMPLEMENTED(); 139 NOTIMPLEMENTED();
140 } 140 }
141 141
142 void FakeGCMDriver::SetAccountTokens(
jianli 2014/09/25 20:26:45 I do not think this will compile.
fgorski 2014/09/26 22:51:42 Done.
143 const std::vector<GCMClient::AccountTokenInfo>& account_tokens) {
144 }
jianli 2014/09/25 20:26:45 Please add either "NOTIMPLEMENTED()" or comment "N
fgorski 2014/09/26 22:51:42 Done. And added to the other account handling meth
145
142 void GCMDriverAndroid::UpdateAccountMapping( 146 void GCMDriverAndroid::UpdateAccountMapping(
143 const AccountMapping& account_mapping) { 147 const AccountMapping& account_mapping) {
144 } 148 }
145 149
146 void GCMDriverAndroid::RemoveAccountMapping(const std::string& account_id) { 150 void GCMDriverAndroid::RemoveAccountMapping(const std::string& account_id) {
147 } 151 }
148 152
149 GCMClient::Result GCMDriverAndroid::EnsureStarted() { 153 GCMClient::Result GCMDriverAndroid::EnsureStarted() {
150 // TODO(johnme): Maybe we should check if GMS is available? 154 // TODO(johnme): Maybe we should check if GMS is available?
151 return GCMClient::SUCCESS; 155 return GCMClient::SUCCESS;
(...skipping 16 matching lines...) Expand all
168 ConvertUTF8ToJavaString(env, app_id).Release()); 172 ConvertUTF8ToJavaString(env, app_id).Release());
169 } 173 }
170 174
171 void GCMDriverAndroid::SendImpl(const std::string& app_id, 175 void GCMDriverAndroid::SendImpl(const std::string& app_id,
172 const std::string& receiver_id, 176 const std::string& receiver_id,
173 const GCMClient::OutgoingMessage& message) { 177 const GCMClient::OutgoingMessage& message) {
174 NOTIMPLEMENTED(); 178 NOTIMPLEMENTED();
175 } 179 }
176 180
177 } // namespace gcm 181 } // namespace gcm
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698