Source/core/frame/FrameDestructionObserver.h - Issue 594083002: Make StorageArea cleanly observe its cached frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameDestructionObserver.h

Issue 594083002: Make StorageArea cleanly observe its cached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make FrameDestructionObserver::observeFrame() protected again Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/FrameDestructionObserver.h

diff --git a/Source/core/frame/FrameDestructionObserver.h b/Source/core/frame/FrameDestructionObserver.h

index 9c6175e4d61f5be6178c5f434449c2574efb2d11..a62d20210447fe2a5986198e606afdd637e4bbd7 100644

--- a/Source/core/frame/FrameDestructionObserver.h

+++ b/Source/core/frame/FrameDestructionObserver.h

@@ -56,10 +56,9 @@ protected:

virtual ~FrameDestructionObserver();

#endif

- RawPtrWillBeWeakMember<LocalFrame> m_frame;

-private:

void observeFrame(LocalFrame*);

+ RawPtrWillBeWeakMember<LocalFrame> m_frame;

};

}

« no previous file with comments | « no previous file | Source/core/frame/FrameDestructionObserver.cpp » ('j') | no next file with comments »