Source/core/frame/FrameDestructionObserver.cpp - Issue 594083002: Make StorageArea cleanly observe its cached frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameDestructionObserver.cpp

Issue 594083002: Make StorageArea cleanly observe its cached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make FrameDestructionObserver::observeFrame() protected again Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/FrameDestructionObserver.cpp

diff --git a/Source/core/frame/FrameDestructionObserver.cpp b/Source/core/frame/FrameDestructionObserver.cpp

index 8ba4ed32c9c9f7bf694aed51acdd8449b2acf6b7..4d755f15a14294705633eb6f63f6e2134030e3c3 100644

--- a/Source/core/frame/FrameDestructionObserver.cpp

+++ b/Source/core/frame/FrameDestructionObserver.cpp

@@ -45,11 +45,8 @@ FrameDestructionObserver::~FrameDestructionObserver()

void FrameDestructionObserver::observeFrame(LocalFrame* frame)

{

- ASSERT(!m_frame || !frame);

-#if !ENABLE(OILPAN)

if (m_frame)

m_frame->removeDestructionObserver(this);

-#endif

m_frame = frame;

« no previous file with comments | « Source/core/frame/FrameDestructionObserver.h ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »