Source/core/frame/FrameDestructionObserver.h - Issue 594083002: Make StorageArea cleanly observe its cached frame

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/FrameDestructionObserver.h

Issue 594083002: Make StorageArea cleanly observe its cached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make FrameDestructionObserver::observeFrame() protected again Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google, Inc. All Rights Reserved.	2 * Copyright (C) 2011 Google, Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49	49

50 LocalFrame* frame() const { return m_frame; }	50 LocalFrame* frame() const { return m_frame; }

51	51

52 virtual void trace(Visitor*);	52 virtual void trace(Visitor*);

53	53

54 protected:	54 protected:

55 #if !ENABLE(OILPAN)	55 #if !ENABLE(OILPAN)

56 virtual ~FrameDestructionObserver();	56 virtual ~FrameDestructionObserver();

57 #endif	57 #endif

58	58

	59 void observeFrame(LocalFrame*);

	60

59 RawPtrWillBeWeakMember<LocalFrame> m_frame;	61 RawPtrWillBeWeakMember<LocalFrame> m_frame;

60

61 private:

62 void observeFrame(LocalFrame*);

63 };	62 };

64	63

65 }	64 }

66	65

67 #endif	66 #endif

OLD	NEW

« no previous file with comments | « no previous file | Source/core/frame/FrameDestructionObserver.cpp » ('j') | no next file with comments »