extensions/browser/api/capture_web_contents_function.h - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/capture_web_contents_function.h

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/capture_web_contents_function.h

diff --git a/extensions/browser/api/capture_web_contents_function.h b/extensions/browser/api/capture_web_contents_function.h

index 7effacd8f46fb2b82277224a911e4b29e8a397ae..9f60234104d0db2760f335efb7778d6de2212586 100644

--- a/extensions/browser/api/capture_web_contents_function.h

+++ b/extensions/browser/api/capture_web_contents_function.h

@@ -5,6 +5,7 @@

#ifndef EXTENSIONS_BROWSER_API_CAPTURE_WEB_CONTENTS_FUNCTION_H_

#define EXTENSIONS_BROWSER_API_CAPTURE_WEB_CONTENTS_FUNCTION_H_

+#include "content/public/browser/readback_types.h"

#include "extensions/browser/extension_function.h"

#include "extensions/common/api/extension_types.h"

@@ -42,7 +43,8 @@ class CaptureWebContentsFunction : public AsyncExtensionFunction {

private:

typedef core_api::extension_types::ImageDetails ImageDetails;

- void CopyFromBackingStoreComplete(bool succeed, const SkBitmap& bitmap);

+ void CopyFromBackingStoreComplete(const SkBitmap& bitmap,

+ content::ReadbackResponse response);

void OnCaptureSuccess(const SkBitmap& bitmap);

// |context_id_| is the ID used to find the relevant WebContents. In the