extensions/browser/api/capture_web_contents_function.cc - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/capture_web_contents_function.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/capture_web_contents_function.cc

diff --git a/extensions/browser/api/capture_web_contents_function.cc b/extensions/browser/api/capture_web_contents_function.cc

index a888284deb42913e5327e45f940c5a2e4f8c6039..611af6fbfe2e13550dbf6053a34dfb8e549ecff1 100644

--- a/extensions/browser/api/capture_web_contents_function.cc

+++ b/extensions/browser/api/capture_web_contents_function.cc

@@ -91,9 +91,9 @@ bool CaptureWebContentsFunction::RunAsync() {

}

void CaptureWebContentsFunction::CopyFromBackingStoreComplete(

- bool succeeded,

- const SkBitmap& bitmap) {

- if (succeeded) {

+ const SkBitmap& bitmap,

+ content::ReadbackResponse response) {

+ if (response == content::READBACK_SUCCESS) {

OnCaptureSuccess(bitmap);

return;

}