content/test/test_render_view_host.cc - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_view_host.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/test_render_view_host.cc

diff --git a/content/test/test_render_view_host.cc b/content/test/test_render_view_host.cc

index 5a83dda164ff2acd6992d09a49920c98f3d0da20..957fae8414caab962749f779a84064186fd75770 100644

--- a/content/test/test_render_view_host.cc

+++ b/content/test/test_render_view_host.cc

@@ -113,9 +113,9 @@ gfx::Rect TestRenderWidgetHostView::GetViewBounds() const {

void TestRenderWidgetHostView::CopyFromCompositingSurface(

const gfx::Rect& src_subrect,

const gfx::Size& dst_size,

- CopyFromCompositingSurfaceCallback& callback,

+ ReadbackRequestCallback& callback,

const SkColorType color_type) {

- callback.Run(false, SkBitmap());

+ callback.Run(SkBitmap(), content::READBACK_NOT_SUPPORTED);

}

void TestRenderWidgetHostView::CopyFromCompositingSurfaceToVideoFrame(