Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/profiles/profile_metrics_mac.mm

Issue 593243002: Profile_Metrics integration with Keystone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better creation of KSReportingAttributes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_metrics_mac.mm
diff --git a/chrome/browser/profiles/profile_metrics_mac.mm b/chrome/browser/profiles/profile_metrics_mac.mm
new file mode 100644
index 0000000000000000000000000000000000000000..1e0b0291567177a7e73990a68a0c1399b297b2ec
--- /dev/null
+++ b/chrome/browser/profiles/profile_metrics_mac.mm
@@ -0,0 +1,18 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
Mark Mentovai 2015/02/20 21:54:19 2015
Mike Lerman 2015/02/23 16:12:11 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/profiles/profile_metrics.h"
+
+#include "base/numerics/safe_conversions.h"
+#include "chrome/browser/mac/keystone_glue.h"
+
+void ProfileMetrics::UpdateReportedOSProfileStatistics(
+ size_t active, size_t signedin) {
+ if (base::IsValueInRangeForNumericType<uint32_t, size_t>(active) &&
Mark Mentovai 2015/02/20 21:54:19 I don’t think the second template parameter is nec
Mike Lerman 2015/02/23 16:12:12 Done.
+ base::IsValueInRangeForNumericType<uint32_t, size_t>(signedin)) {
+ [[KeystoneGlue defaultKeystoneGlue]
+ updateProfileCountsWithNumProfiles:(uint32_t)active
Mark Mentovai 2015/02/20 21:54:19 I don’t think these casts are necessary.
Mike Lerman 2015/02/23 16:12:11 Done.
+ numSignedInProfiles:(uint32_t)signedin];
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698