chrome/browser/profiles/profile_metrics_mac.mm - Issue 593243002: Profile_Metrics integration with Keystone

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/profiles/profile_metrics_mac.mm

Issue 593243002: Profile_Metrics integration with Keystone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Better creation of KSReportingAttributes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	Mark Mentovai 2015/02/20 21:54:19 2015 2015 Mike Lerman 2015/02/23 16:12:11 Done. Show quoted text On 2015/02/20 21:54:19, Mark Mentovai wrote: > 2015 Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/profiles/profile_metrics.h"

	6

	7 #include "base/numerics/safe_conversions.h"

	8 #include "chrome/browser/mac/keystone_glue.h"

	9

	10 void ProfileMetrics::UpdateReportedOSProfileStatistics(

	11 size_t active, size_t signedin) {

	12 if (base::IsValueInRangeForNumericType<uint32_t, size_t>(active) &&
	Mark Mentovai 2015/02/20 21:54:19 I don’t think the second template parameter is nec I don’t think the second template parameter is necessary, it’s implied by the type of the function argument. Mike Lerman 2015/02/23 16:12:12 Done. Show quoted text On 2015/02/20 21:54:19, Mark Mentovai wrote: > I don’t think the second template parameter is necessary, it’s implied by the > type of the function argument. Done.
	13 base::IsValueInRangeForNumericType<uint32_t, size_t>(signedin)) {

	14 [[KeystoneGlue defaultKeystoneGlue]

	15 updateProfileCountsWithNumProfiles:(uint32_t)active
	Mark Mentovai 2015/02/20 21:54:19 I don’t think these casts are necessary. I don’t think these casts are necessary. Mike Lerman 2015/02/23 16:12:11 Done. Show quoted text On 2015/02/20 21:54:19, Mark Mentovai wrote: > I don’t think these casts are necessary. Done.
	16 numSignedInProfiles:(uint32_t)signedin];

	17 }

	18 }

OLD	NEW