Profile_Metrics integration with Keystone

chrome/installer/util/google_update_settings.h

Index: chrome/installer/util/google_update_settings.h
diff --git a/chrome/installer/util/google_update_settings.h b/chrome/installer/util/google_update_settings.h
index ea5a7d5878f9b49c9fcfb57ceae741d7460f7f1e..e3a01685f1974c20741a8a8cd5322ccef0f357b6 100644
--- a/chrome/installer/util/google_update_settings.h
+++ b/chrome/installer/util/google_update_settings.h
@@ -218,7 +218,8 @@ class GoogleUpdateSettings {
 
   // This method updates the values that report how many profiles are in use
   // and how many of those are signed-in.
-  static void UpdateProfileCounts(int profiles_active, int profiles_signedin);
+  static void UpdateProfileCounts(size_t profiles_active,

[grt (UTC plus 2), 2015/02/21 00:08:47]

Why size_t?
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types

[Mike Lerman, 2015/02/23 16:12:12]

I went with size_t because that's what we tend to use in profiles when there's a
non-negative number, e.g. a count of profiles, an iterator over profiles, or an
index into the ProfileInfoCache. That link you mention notes that size_t is
acceptable to use.

mark@ prefers the parameter passed to Keystone be of an unsigned type, so I
wanted to be consistent to the windows side as well.

[grt (UTC plus 2), 2015/02/23 20:50:01]

That seems to run contrary to "In particular, do not use unsigned types to say a
number will never be negative." size_t is unambiguously correct when used to
index into a std container (e.g., iterating over a vector), but it's less clear
to me that "there will never be a negative number of profiles" is a good reason.
My take on the style guide is that int is the correct type for this.

Mark: why do you prefer an unsigned type for Keystone?

+                                  size_t profiles_signedin);
 
   // For system-level installs, we need to be able to communicate the results
   // of the Toast Experiments back to Google Update. The problem is just that