Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 591783003: Refactoring: Remove more legacy from release scripts. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 2 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactoring: Remove more legacy from release scripts. - Remove an unused feature that allowed to check for required data before each script step. - Use a relative path to the version file. In the production environment, this will point to the cwd/version_file, while in the test environment it is fake_cwd/version_file. TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24140

Patch Set 1 : Remove "requires" feature. #

Patch Set 2 : Read version file relative to cwd. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -82 lines) Patch
M tools/push-to-trunk/auto_tag.py View 1 3 chunks +2 lines, -3 lines 1 comment Download
M tools/push-to-trunk/bump_up_version.py View 1 4 chunks +3 lines, -4 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 1 5 chunks +5 lines, -13 lines 0 comments Download
M tools/push-to-trunk/merge_to_branch.py View 1 2 chunks +4 lines, -5 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 7 chunks +10 lines, -12 lines 0 comments Download
M tools/push-to-trunk/releases.py View 1 3 chunks +3 lines, -4 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 19 chunks +30 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL
6 years, 3 months ago (2014-09-23 07:40:40 UTC) #2
Michael Achenbach
Committed patchset #2 (id:20001) manually as 24140 (presubmit successful).
6 years, 3 months ago (2014-09-23 09:36:17 UTC) #3
tandrii(chromium)
lgtm https://codereview.chromium.org/591783003/diff/20001/tools/push-to-trunk/auto_tag.py File tools/push-to-trunk/auto_tag.py (right): https://codereview.chromium.org/591783003/diff/20001/tools/push-to-trunk/auto_tag.py#newcode10 tools/push-to-trunk/auto_tag.py:10: I guess this is historical, but * imports ...
6 years, 3 months ago (2014-09-23 14:39:54 UTC) #4
Michael Achenbach
6 years, 2 months ago (2014-09-25 08:21:45 UTC) #5
Message was sent while issue was closed.
On 2014/09/23 14:39:54, tandrii wrote:
> lgtm
> 
>
https://codereview.chromium.org/591783003/diff/20001/tools/push-to-trunk/auto...
> File tools/push-to-trunk/auto_tag.py (right):
> 
>
https://codereview.chromium.org/591783003/diff/20001/tools/push-to-trunk/auto...
> tools/push-to-trunk/auto_tag.py:10: 
> I guess this is historical, but * imports make it difficult to figure out
where
> things come from, like VERSION_FILE :(

Totally :-/

I'll try to improve this step by step...

Powered by Google App Engine
This is Rietveld 408576698