Refactoring: Remove more legacy from release scripts.

tools/push-to-trunk/auto_tag.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import sys
 
 from common_includes import *
 

[tandrii(chromium), 2014/09/23 14:39:54]

I guess this is historical, but * imports make it difficult to figure out where
things come from, like VERSION_FILE :(

 CONFIG = {
   BRANCHNAME: "auto-tag-v8",
   PERSISTFILE_BASENAME: "/tmp/v8-auto-tag-tempfile",
-  VERSION_FILE: "src/version.cc",
 }
 
 
 class Preparation(Step):
   MESSAGE = "Preparation."
 
   def RunStep(self):
     self.CommonPrepare()
     self.PrepareBranch()
     self.GitCheckout("master")
@@ skipping 22 matching lines @@
     self["candidate"] = None
     self["candidate_version"] = None
     self["next"] = None
     self["next_version"] = None
 
     # Iterate backwards through all automatic version updates.
     for git_hash in self.GitLog(
         format="%H", grep="\\[Auto\\-roll\\] Bump up version to").splitlines():
 
       # Get the version.
-      if not self.GitCheckoutFileSafe(self._config[VERSION_FILE], git_hash):
+      if not self.GitCheckoutFileSafe(VERSION_FILE, git_hash):
         continue
 
       self.ReadAndPersistVersion()
       version = self.ArrayToVersion("")
 
       # Strip off trailing patch level (tags don't include tag level 0).
       if version.endswith(".0"):
         version = version[:-2]
 
       # Clean up checked-out version file.
-      self.GitCheckoutFileSafe(self._config[VERSION_FILE], "HEAD")
+      self.GitCheckoutFileSafe(VERSION_FILE, "HEAD")
 
       if version in tags:
         if self["candidate"]:
           # Revision "git_hash" is tagged already and "candidate" was the next
           # newer revision without a tag.
           break
         else:
           print("Stop as %s is the latest version and it has been tagged." %
                 version)
           self.CommonCleanup()
@@ skipping 111 matching lines @@
       GetOldestUntaggedVersion,
       GetLKGRs,
       CalculateTagRevision,
       MakeTag,
       CleanUp,
     ]
 
 
 if __name__ == "__main__":  # pragma: no cover
   sys.exit(AutoTag(CONFIG).Run())