Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: tools/push-to-trunk/auto_tag.py

Issue 591783003: Refactoring: Remove more legacy from release scripts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Read version file relative to cwd. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/push-to-trunk/bump_up_version.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/push-to-trunk/auto_tag.py
diff --git a/tools/push-to-trunk/auto_tag.py b/tools/push-to-trunk/auto_tag.py
index 007a50d5f884e2aa2cca538593fa7155338680eb..080089682c3b7a863c8265e9d94d06af5e11c468 100755
--- a/tools/push-to-trunk/auto_tag.py
+++ b/tools/push-to-trunk/auto_tag.py
@@ -11,7 +11,6 @@ from common_includes import *
CONFIG = {
BRANCHNAME: "auto-tag-v8",
PERSISTFILE_BASENAME: "/tmp/v8-auto-tag-tempfile",
- VERSION_FILE: "src/version.cc",
}
@@ -54,7 +53,7 @@ class GetOldestUntaggedVersion(Step):
format="%H", grep="\\[Auto\\-roll\\] Bump up version to").splitlines():
# Get the version.
- if not self.GitCheckoutFileSafe(self._config[VERSION_FILE], git_hash):
+ if not self.GitCheckoutFileSafe(VERSION_FILE, git_hash):
continue
self.ReadAndPersistVersion()
@@ -65,7 +64,7 @@ class GetOldestUntaggedVersion(Step):
version = version[:-2]
# Clean up checked-out version file.
- self.GitCheckoutFileSafe(self._config[VERSION_FILE], "HEAD")
+ self.GitCheckoutFileSafe(VERSION_FILE, "HEAD")
if version in tags:
if self["candidate"]:
« no previous file with comments | « no previous file | tools/push-to-trunk/bump_up_version.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698