Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 591613003: Move painting code from RenderObject into a new ObjectPainter class. (Closed)

Created:
6 years, 3 months ago by chrishtr
Modified:
6 years, 3 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Move painting code from RenderObject into a new ObjectPainter class. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182367

Patch Set 1 #

Patch Set 2 : Merged. #

Patch Set 3 : Merge again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -365 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/BlockPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/BoxPainter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
A Source/core/paint/ObjectPainter.h View 1 chunk +43 lines, -0 lines 0 comments Download
A Source/core/paint/ObjectPainter.cpp View 1 chunk +349 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 10 chunks +10 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 3 chunks +0 lines, -21 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 3 chunks +4 lines, -330 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
chrishtr
6 years, 3 months ago (2014-09-19 21:08:22 UTC) #2
leviw_travelin_and_unemployed
6 years, 3 months ago (2014-09-19 21:10:37 UTC) #4
pdr.
On 2014/09/19 21:08:22, chrishtr wrote: LGTM
6 years, 3 months ago (2014-09-19 21:12:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591613003/1
6 years, 3 months ago (2014-09-19 21:13:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/27986)
6 years, 3 months ago (2014-09-20 02:13:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591613003/20001
6 years, 3 months ago (2014-09-20 04:28:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/27995)
6 years, 3 months ago (2014-09-20 05:21:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591613003/40001
6 years, 3 months ago (2014-09-20 05:33:20 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 06:40:33 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 182367

Powered by Google App Engine
This is Rietveld 408576698