Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 59153004: Revert 233787 "Eliminate Shell::RootWindowList in favor of aura:..." (Closed)

Created:
7 years, 1 month ago by Ben Goodger (Google)
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 233787 "Eliminate Shell::RootWindowList in favor of aura:..." > Eliminate Shell::RootWindowList in favor of aura::Window::Windows. > > This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. > > R=oshima@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/64933002 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -272 lines) Patch
M trunk/src/ash/accelerators/accelerator_controller.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/ash/accelerators/accelerator_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/autoclick/autoclick_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/debug.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/ash/desktop_background/desktop_background_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/desktop_background/desktop_background_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/desktop_background/desktop_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/display/display_controller.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ash/display/display_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/display/display_controller_unittest.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M trunk/src/ash/display/display_manager_unittest.cc View 4 chunks +20 lines, -23 lines 0 comments Download
M trunk/src/ash/display/mouse_cursor_event_filter_unittest.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M trunk/src/ash/display/output_configurator_animation.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ash/display/output_configurator_animation.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/ash/display/root_window_transformers_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/ash/display/screen_position_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/ash/display/screen_position_controller_unittest.cc View 4 chunks +12 lines, -20 lines 0 comments Download
M trunk/src/ash/drag_drop/drag_drop_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/drag_drop/drag_drop_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/drag_drop/drag_drop_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/extended_desktop_unittest.cc View 19 chunks +26 lines, -28 lines 0 comments Download
M trunk/src/ash/high_contrast/high_contrast_controller.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ash/high_contrast/high_contrast_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/magnifier/partial_magnification_controller.h View 2 chunks +5 lines, -1 line 0 comments Download
M trunk/src/ash/magnifier/partial_magnification_controller.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/ash/root_window_controller_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shelf/shelf_widget_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shell.h View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/shell.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/shell/window_watcher.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/src/ash/shell_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/touch/touch_hud_debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/ash_native_cursor_manager.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/drag_window_resizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/drag_window_resizer_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/ash/wm/immersive_fullscreen_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/mru_window_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/overview/window_overview.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/overview/window_selector.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/wm/overview/window_selector_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/ash/wm/panels/panel_layout_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/wm/panels/panel_window_resizer_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/ash/wm/partial_screenshot_view.h View 2 chunks +5 lines, -1 line 0 comments Download
M trunk/src/ash/wm/partial_screenshot_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/window_cycle_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/workspace/phantom_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/workspace/workspace_layout_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/workspace/workspace_window_resizer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/ash_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/multi_user_window_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/screenshot_taker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
7 years, 1 month ago (2013-11-08 07:16:03 UTC) #1
Ben Goodger (Google)
7 years, 1 month ago (2013-11-08 07:16:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r233813.

Powered by Google App Engine
This is Rietveld 408576698