Remove implicit conversions from scoped_refptr to T* in chrome/

Remove implicit conversions from scoped_refptr to T* in chrome/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG=110610
Committed: https://crrev.com/037fdb5001271435af339b1d165e5512004eb160
Cr-Commit-Position: refs/heads/master@{#295854}

[dcheng, 2014-09-19 17:04:11]

dcheng@chromium.org changed reviewers:
+ sky@chromium.org

[Lei Zhang, 2014-09-19 18:38:59]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2014-09-19 18:38:59]

lgtm

https://codereview.chromium.org/591493002/diff/1/chrome/browser/ui/cocoa/ssl_...
File
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
(right):

https://codereview.chromium.org/591493002/diff/1/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm:51:
SSLClientCertificateSelectorCocoa* selector = [
nit: is this the preferred objc style?

[dcheng, 2014-09-19 19:23:47]

dcheng@chromium.org changed reviewers:
+ rsesek@chromium.org

[dcheng, 2014-09-19 19:23:47]

+rsesek for insight into the formatting details.

https://codereview.chromium.org/591493002/diff/1/chrome/browser/ui/cocoa/ssl_...
File
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
(right):

https://codereview.chromium.org/591493002/diff/1/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm:51:
SSLClientCertificateSelectorCocoa* selector = [
On 2014/09/19 18:38:59, Lei Zhang wrote:
> nit: is this the preferred objc style?

I'm not sure. It looks like the formatter is aware of objc styling though, given
how it lined up the colons. I'll double-check with a Mac person.

[Robert Sesek, 2014-09-19 20:26:01]

https://codereview.chromium.org/591493002/diff/1/chrome/browser/ui/cocoa/ssl_...
File
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
(right):

https://codereview.chromium.org/591493002/diff/1/chrome/browser/ui/cocoa/ssl_...
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm:51:
SSLClientCertificateSelectorCocoa* selector = [
On 2014/09/19 19:23:47, dcheng (OOO) wrote:
> On 2014/09/19 18:38:59, Lei Zhang wrote:
> > nit: is this the preferred objc style?
> 
> I'm not sure. It looks like the formatter is aware of objc styling though,
given
> how it lined up the colons. I'll double-check with a Mac person.

clang-format technically has support for ObjC, but it often does heinous things
like this. The original formatting here is correct.

[dcheng, 2014-09-19 22:48:50]

On 2014/09/19 at 20:26:01, rsesek wrote:
>
https://codereview.chromium.org/591493002/diff/1/chrome/browser/ui/cocoa/ssl_...
> File
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
(right):
> 
>
https://codereview.chromium.org/591493002/diff/1/chrome/browser/ui/cocoa/ssl_...
>
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm:51:
SSLClientCertificateSelectorCocoa* selector = [
> On 2014/09/19 19:23:47, dcheng (OOO) wrote:
> > On 2014/09/19 18:38:59, Lei Zhang wrote:
> > > nit: is this the preferred objc style?
> > 
> > I'm not sure. It looks like the formatter is aware of objc styling though,
given
> > how it lined up the colons. I'll double-check with a Mac person.
> 
> clang-format technically has support for ObjC, but it often does heinous
things like this. The original formatting here is correct.

Thanks. Fixed, and I'll file a bug against clang-format, since bad formatting
like this will increase the resistance towards clang-formatting all the things.

[dcheng, 2014-09-20 00:54:50]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-09-20 00:56:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591493002/20001

[commit-bot: I haz the power, 2014-09-20 02:58:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-20 02:58:51]

Exceeded time limit waiting for builds to trigger.

[Lei Zhang, 2014-09-20 03:01:40]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-09-20 03:02:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591493002/20001

[commit-bot: I haz the power, 2014-09-20 03:22:16]

Committed patchset #2 (id:20001) as 8230d09188493d61c9232c29ccbbd5cd39e90701

[commit-bot: I haz the power, 2014-09-20 03:22:20]

Failed to apply the patch.

[commit-bot: I haz the power, 2014-09-20 03:22:52]

Patchset 2 (id:??) landed as
https://crrev.com/037fdb5001271435af339b1d165e5512004eb160
Cr-Commit-Position: refs/heads/master@{#295854}