chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm - Issue 591493002: Remove implicit conversions from scoped_refptr to T* in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm

Issue 591493002: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatting Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/picasa_data_provider.cc ('k') | chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm b/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm

index 96a79e3f0fb9e07cbe6b1937554093a3582449ff..63e03f2e8dbc885297e4eb7de7fc7e1230cb7b7d 100644

--- a/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm

@@ -79,14 +79,14 @@ OriginChipDecoration::OriginChipDecoration(

// May not be set for unit tests.

scoped_refptr<SafeBrowsingService> sb_service =

g_browser_process->safe_browsing_service();

- if (sb_service.get() && sb_service->ui_manager())

+ if (sb_service.get() && sb_service->ui_manager().get())

sb_service->ui_manager()->AddObserver(this);

}

OriginChipDecoration::~OriginChipDecoration() {

scoped_refptr<SafeBrowsingService> sb_service =

g_browser_process->safe_browsing_service();

- if (sb_service.get() && sb_service->ui_manager())

+ if (sb_service.get() && sb_service->ui_manager().get())

sb_service->ui_manager()->RemoveObserver(this);

}