Remove implicit conversions from scoped_refptr to T* in chrome/

chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h"
 
 #import <SecurityInterface/SFChooseIdentityPanel.h>
 
 #include "base/bind.h"
 #import "base/mac/mac_util.h"
@@ skipping 30 matching lines @@
     return;
 
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   WebContentsModalDialogManager* web_contents_modal_dialog_manager =
       WebContentsModalDialogManager::FromWebContents(web_contents);
   EXPECT_FALSE(web_contents_modal_dialog_manager->IsDialogActive());
 
   net::X509Certificate* cert = NULL;
   int count = 0;
-  SSLClientCertificateSelectorCocoa* selector =
-      [[SSLClientCertificateSelectorCocoa alloc]
-          initWithNetworkSession:auth_requestor_->http_network_session_
-                 certRequestInfo:auth_requestor_->cert_request_info_
-                        callback:base::Bind(&OnCertificateSelected,
-                                            &cert,
-                                            &count)];
+  SSLClientCertificateSelectorCocoa* selector = [

[Lei Zhang, 2014/09/19 18:38:59]

nit: is this the preferred objc style?

[dcheng, 2014/09/19 19:23:47]

I'm not sure. It looks like the formatter is aware of objc styling though, given
how it lined up the colons. I'll double-check with a Mac person.

[Robert Sesek, 2014/09/19 20:26:01]

clang-format technically has support for ObjC, but it often does heinous things
like this. The original formatting here is correct.

+      [SSLClientCertificateSelectorCocoa alloc]
+      initWithNetworkSession:auth_requestor_->http_network_session_
+             certRequestInfo:auth_requestor_->cert_request_info_.get()
+                    callback:base::Bind(&OnCertificateSelected, &cert, &count)];
   [selector displayForWebContents:web_contents];
   content::RunAllPendingInMessageLoop();
   EXPECT_TRUE([selector panel]);
   EXPECT_TRUE(web_contents_modal_dialog_manager->IsDialogActive());
 
   WebContentsModalDialogManager::TestApi test_api(
       web_contents_modal_dialog_manager);
   test_api.CloseAllDialogs();
   content::RunAllPendingInMessageLoop();
   EXPECT_FALSE(web_contents_modal_dialog_manager->IsDialogActive());
 
   EXPECT_EQ(NULL, cert);
   EXPECT_EQ(1, count);
 }
 
 // Test that switching to another tab correctly hides the sheet.
 IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, HideShow) {
   SSLClientCertificateSelectorCocoa* selector =
       [[SSLClientCertificateSelectorCocoa alloc]
           initWithNetworkSession:auth_requestor_->http_network_session_
-                 certRequestInfo:auth_requestor_->cert_request_info_
+                 certRequestInfo:auth_requestor_->cert_request_info_.get()
                         callback:chrome::SelectCertificateCallback()];
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   [selector displayForWebContents:web_contents];
   content::RunAllPendingInMessageLoop();
 
   NSWindow* sheetWindow = [[selector overlayWindow] attachedSheet];
   NSRect sheetFrame = [sheetWindow frame];
   EXPECT_EQ(1.0, [sheetWindow alphaValue]);
 
   // Switch to another tab and verify that the sheet is hidden.
   AddBlankTabAndShow(browser());
   EXPECT_EQ(0.0, [sheetWindow alphaValue]);
   EXPECT_TRUE(NSEqualRects(ui::kWindowSizeDeterminedLater,
                            [sheetWindow frame]));
 
   // Switch back and verify that the sheet is shown.
   chrome::SelectNumberedTab(browser(), 0);
   EXPECT_EQ(1.0, [sheetWindow alphaValue]);
   EXPECT_TRUE(NSEqualRects(sheetFrame, [sheetWindow frame]));
 }